Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2926113003: Changes subresource filtering icon in the omnibar. (Closed)

Created:
3 years, 6 months ago by shivanisha
Modified:
3 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Charlie Harrison, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes subresource filtering icon in the omnibar. Snapshot attached in the bug. BUG=689992 Review-Url: https://codereview.chromium.org/2926113003 Cr-Commit-Position: refs/heads/master@{#477720} Committed: https://chromium.googlesource.com/chromium/src/+/cd8fc10c1957222029a90b230e90f3a0e0952cfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -12 lines) Patch
M chrome/app/vector_icons/subresource_filter_active.icon View 1 chunk +40 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
shivanisha
estade@, PTAL, Thanks!
3 years, 6 months ago (2017-06-07 16:25:58 UTC) #3
Evan Stade
lgtm
3 years, 6 months ago (2017-06-07 16:41:06 UTC) #6
shivanisha
On 2017/06/07 at 16:41:06, estade wrote: > lgtm Thanks Evan!
3 years, 6 months ago (2017-06-07 19:01:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926113003/1
3 years, 6 months ago (2017-06-07 19:01:13 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 19:07:46 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd8fc10c1957222029a90b230e90...

Powered by Google App Engine
This is Rietveld 408576698