Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2926113002: Relocate stability report extraction tests to seperate file (Closed)

Created:
3 years, 6 months ago by manzagop (departed)
Modified:
3 years, 6 months ago
Reviewers:
bcwhite
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Relocate stability report extraction tests to seperate file BUG=691595 Review-Url: https://codereview.chromium.org/2926113002 Cr-Commit-Position: refs/heads/master@{#477725} Committed: https://chromium.googlesource.com/chromium/src/+/1a95d3f14a92b9377d8d94885414a6b1ce2710db

Patch Set 1 #

Patch Set 2 : diff detect the move #

Patch Set 3 : remove unused var/function (thanks clang) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -789 lines) Patch
M components/browser_watcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_watcher/postmortem_report_collector_unittest.cc View 1 2 3 chunks +0 lines, -384 lines 0 comments Download
A + components/browser_watcher/stability_report_extractor_unittest.cc View 1 15 chunks +20 lines, -405 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
manzagop (departed)
Hi Brian, Relocating some code: nothing new! Could you have a look? Thanks! P-A
3 years, 6 months ago (2017-06-07 15:00:29 UTC) #6
bcwhite
On 2017/06/07 15:00:29, manzagop wrote: > Hi Brian, > > Relocating some code: nothing new! ...
3 years, 6 months ago (2017-06-07 16:06:35 UTC) #7
manzagop (departed)
On 2017/06/07 16:06:35, bcwhite wrote: > On 2017/06/07 15:00:29, manzagop wrote: > > Hi Brian, ...
3 years, 6 months ago (2017-06-07 16:08:32 UTC) #8
bcwhite
lgtm
3 years, 6 months ago (2017-06-07 17:23:50 UTC) #11
manzagop (departed)
Thanks for the review!
3 years, 6 months ago (2017-06-07 17:49:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926113002/40001
3 years, 6 months ago (2017-06-07 17:49:57 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 19:29:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1a95d3f14a92b9377d8d94885414...

Powered by Google App Engine
This is Rietveld 408576698