[interpreter] Make sure allocated registers are always materialized in the register optimizer.

[interpreter] Make sure allocated registers are always materialized in the register optimizer.

BUG=chromium:729369
Review-Url: https://codereview.chromium.org/2926063002
Cr-Commit-Position: refs/heads/master@{#45770}
Committed: https://chromium.googlesource.com/v8/v8/+/b543c2daba2e5e18b3abeabed132480e1bfbbd54

[Jarin, 2017-06-07 08:35:47]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 08:35:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-06-07 08:36:28]

jarin@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Jarin, 2017-06-07 08:36:29]

Is this what you had in mind?

[commit-bot: I haz the power, 2017-06-07 09:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 09:04:08]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2017-06-07 13:01:58]

LGTM with a nit. Let's try it and see if it impacts performance anyway (seems to
improve register optimization from the changes in the golden files, so that's
nice :).

https://codereview.chromium.org/2926063002/diff/1/src/interpreter/bytecode-re...
File src/interpreter/bytecode-register-optimizer.cc (right):

https://codereview.chromium.org/2926063002/diff/1/src/interpreter/bytecode-re...
src/interpreter/bytecode-register-optimizer.cc:419: void
BytecodeRegisterOptimizer::SetRegisterAllocated(Register reg) {
nit - could you pull out the GetOrCreateRegisterInfo to the caller so that
RegisterListAllocateEvent can continue to use GetRegisterInfo. Also, maybe just
AllocateRegister as the name?

[Jarin, 2017-06-07 15:11:34]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 15:11:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-06-07 15:14:07]

https://codereview.chromium.org/2926063002/diff/1/src/interpreter/bytecode-re...
File src/interpreter/bytecode-register-optimizer.cc (right):

https://codereview.chromium.org/2926063002/diff/1/src/interpreter/bytecode-re...
src/interpreter/bytecode-register-optimizer.cc:419: void
BytecodeRegisterOptimizer::SetRegisterAllocated(Register reg) {
On 2017/06/07 13:01:58, rmcilroy wrote:
> nit - could you pull out the GetOrCreateRegisterInfo to the caller so that
> RegisterListAllocateEvent can continue to use GetRegisterInfo. Also, maybe
just
> AllocateRegister as the name?

Done.

[Jarin, 2017-06-07 15:19:19]

The CQ bit was unchecked by jarin@chromium.org

[Jarin, 2017-06-07 15:19:19]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2017-06-07 15:19:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2926063002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-06-07 15:19:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 15:39:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496848759679110,
"parent_rev": "2851fedeef02e4450d0a40daee6061e176912036", "commit_rev":
"b543c2daba2e5e18b3abeabed132480e1bfbbd54"}

[commit-bot: I haz the power, 2017-06-07 15:40:08]

Description was changed from

==========
[interpreter] Make sure allocated registers are always materialized in the
register optimizer.

BUG=chromium:729369
==========

to

==========
[interpreter] Make sure allocated registers are always materialized in the
register optimizer.

BUG=chromium:729369

Review-Url: https://codereview.chromium.org/2926063002
Cr-Commit-Position: refs/heads/master@{#45770}
Committed:
https://chromium.googlesource.com/v8/v8/+/b543c2daba2e5e18b3abeabed132480e1bf...
==========

[commit-bot: I haz the power, 2017-06-07 15:40:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b543c2daba2e5e18b3abeabed132480e1bf...