Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2926043005: PPC/s390: Inline Array.prototype.forEach in TurboFan (Closed)

Created:
3 years, 6 months ago by JaideepBajwa
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Inline Array.prototype.forEach in TurboFan Port 90c3a2d54b956d06ace2c97c6bfdb10ea9cb8e58 Original Commit Message: This CL contains a few pieces: - A new mechanism to create "BuiltinContinuation" checkpoints in TurboFan graphs, which--when triggered--swizzle the values in the the FrameState to be parameters to a typically TF-generated builtin that resumes execution to finish the slow-case functionality. - Continuation builtins that have special handling in the deoptimizer and their own new frame type to ensure that the values they need to begin executing can be stashed away and restored immediately before the builtin is called via a trampoline that runs when the continuation builtin's frame execution resumes. - An implementation of Array.prototype.forEach in TurboFan that can be used to inline it. The inlined forEach implementation uses the checkpoints mechanism described above to deopt in the middle of the forEach in the cases that optimization invariants are violated. There is a slightly different continuation stub for each deopt point in the forEach implementation to ensure the correct side-effects, i.e. that the deopt of the builtin isn't programmatically observable. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2926043005 Cr-Commit-Position: refs/heads/master@{#45798} Committed: https://chromium.googlesource.com/v8/v8/+/0732cbee894c0e518db9c2f337be3794aa46a681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -0 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 6 months ago (2017-06-08 21:07:00 UTC) #1
john.yan
lgtm
3 years, 6 months ago (2017-06-08 21:09:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926043005/1
3 years, 6 months ago (2017-06-08 21:09:51 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 21:34:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0732cbee894c0e518db9c2f337be3794aa4...

Powered by Google App Engine
This is Rietveld 408576698