Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2926023003: Rename SupervisorBridge::whitelists() to GetWhiteLists(). (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SupervisorBridge::whitelists() to GetWhiteLists(). The virtual function is not a trivial accessor. Review-Url: https://codereview.chromium.org/2926023003 Cr-Commit-Position: refs/heads/master@{#478035} Committed: https://chromium.googlesource.com/chromium/src/+/cff6d8710b93d7568a0c5639f1793980aea2d03b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.h View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
Just being nitty.
3 years, 6 months ago (2017-06-08 05:09:35 UTC) #6
Bernhard Bauer
LGTM, thanks!
3 years, 6 months ago (2017-06-08 09:27:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926023003/1
3 years, 6 months ago (2017-06-08 18:25:06 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 18:30:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cff6d8710b93d7568a0c5639f179...

Powered by Google App Engine
This is Rietveld 408576698