Check for gaps between file blocks in zip.

Check for gaps between file blocks in zip.

This is the last remaining additional check on the zip I was planning to perform.

BUG=721530
Review-Url: https://codereview.chromium.org/2925903005
Cr-Commit-Position: refs/heads/master@{#477946}
Committed: https://chromium.googlesource.com/chromium/src/+/e65976a47f9e9fb009879446015845a336c5a816

[ScottK, 2017-06-06 21:30:04]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 21:30:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-06-06 21:36:24]

Description was changed from

==========
Check for gaps between file blocks in zip.

BUG=721530
==========

to

==========
Check for gaps between file blocks in zip.

This is the last remaining additional check on the zip I was planning to
perform.

BUG=721530
==========

[ScottK, 2017-06-06 21:36:24]

scottkirkwood@chromium.org changed reviewers:
+ yfriedman@chromium.org

[commit-bot: I haz the power, 2017-06-06 22:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 22:38:31]

Dry run: This issue passed the CQ dry run.

[Yaron, 2017-06-07 15:10:37]

why didn't any of the tryjobs fail? Aren't you missing the test data file?

https://codereview.chromium.org/2925903005/diff/1/chrome/android/webapk/libs/...
File
chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java
(right):

https://codereview.chromium.org/2925903005/diff/1/chrome/android/webapk/libs/...
chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:232:
"block-before-eocd.apk", "block-before-cd.apk", "block-middle.apk",
missing from patchset?

[ScottK, 2017-06-07 19:00:12]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 19:00:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-06-07 19:07:37]

Nice catch. I've added deeper tests so this type of error won't occur in the
future.

https://codereview.chromium.org/2925903005/diff/1/chrome/android/webapk/libs/...
File
chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java
(right):

https://codereview.chromium.org/2925903005/diff/1/chrome/android/webapk/libs/...
chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:232:
"block-before-eocd.apk", "block-before-cd.apk", "block-middle.apk",
On 2017/06/07 15:10:37, Yaron wrote:
> missing from patchset?

Yes, I thought the file was already there, and that's why it passed, but it
passed because a missing file also returns an "false" for isValidWebApk().

To avoid this error in the future I've added tests at a lower level and check
for specific error conditions.

It also looks like one of the tests doesn't fail in the location I was expecting
and I think it is because of the fuzzing code isn't doing a good enough job.

[commit-bot: I haz the power, 2017-06-07 19:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 19:18:08]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ScottK, 2017-06-08 00:01:39]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 00:02:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 01:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 01:15:28]

Dry run: This issue passed the CQ dry run.

[Yaron, 2017-06-08 04:45:24]

lgtm

[ScottK, 2017-06-08 12:04:40]

The CQ bit was checked by scottkirkwood@chromium.org

[commit-bot: I haz the power, 2017-06-08 12:04:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 12:09:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496923480820930,
"parent_rev": "ba340c5a017d8a9cc6806f5e4af35bd40f2f64ac", "commit_rev":
"e65976a47f9e9fb009879446015845a336c5a816"}

[commit-bot: I haz the power, 2017-06-08 12:09:19]

Description was changed from

==========
Check for gaps between file blocks in zip.

This is the last remaining additional check on the zip I was planning to
perform.

BUG=721530
==========

to

==========
Check for gaps between file blocks in zip.

This is the last remaining additional check on the zip I was planning to
perform.

BUG=721530

Review-Url: https://codereview.chromium.org/2925903005
Cr-Commit-Position: refs/heads/master@{#477946}
Committed:
https://chromium.googlesource.com/chromium/src/+/e65976a47f9e9fb0098794460158...
==========

[commit-bot: I haz the power, 2017-06-08 12:09:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e65976a47f9e9fb0098794460158...