Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2925903004: Add support for blob urls for subresources. (Closed)

Created:
3 years, 6 months ago by jam
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for blob urls for subresources. BUG=715677 Review-Url: https://codereview.chromium.org/2925903004 Cr-Commit-Position: refs/heads/master@{#477539} Committed: https://chromium.googlesource.com/chromium/src/+/188f19f9e26e879ac7aab7ac4bc54ba8cc57eb91

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Total comments: 2

Patch Set 3 : review comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -16 lines) Patch
M content/browser/blob_storage/blob_url_loader_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/blob_storage/blob_url_loader_factory.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 5 chunks +9 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 5 chunks +23 lines, -0 lines 0 comments Download
M content/browser/url_loader_factory_getter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/common/renderer_host.mojom View 1 1 chunk +14 lines, -0 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +12 lines, -1 line 1 comment Download
M content/renderer/render_thread_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
jam
Daniel: security review of mojom/manifest (and anything else you want) Ken: overall
3 years, 6 months ago (2017-06-06 21:43:20 UTC) #4
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2925903004/diff/1/content/common/renderer_host.mojom File content/common/renderer_host.mojom (right): https://codereview.chromium.org/2925903004/diff/1/content/common/renderer_host.mojom#newcode12 content/common/renderer_host.mojom:12: // Returns a URLLoaderFactory for the blob scheme. ...
3 years, 6 months ago (2017-06-06 21:49:58 UTC) #5
jam
https://codereview.chromium.org/2925903004/diff/1/content/common/renderer_host.mojom File content/common/renderer_host.mojom (right): https://codereview.chromium.org/2925903004/diff/1/content/common/renderer_host.mojom#newcode12 content/common/renderer_host.mojom:12: // Returns a URLLoaderFactory for the blob scheme. On ...
3 years, 6 months ago (2017-06-06 22:14:39 UTC) #9
dcheng
mojo lgtm https://codereview.chromium.org/2925903004/diff/20001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/2925903004/diff/20001/content/renderer/render_thread_impl.cc#newcode1088 content/renderer/render_thread_impl.cc:1088: if (!renderer_host_.get()) { Nit: no .get(), here ...
3 years, 6 months ago (2017-06-06 23:05:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925903004/40001
3 years, 6 months ago (2017-06-07 00:03:45 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/232096)
3 years, 6 months ago (2017-06-07 01:11:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925903004/40001
3 years, 6 months ago (2017-06-07 03:32:36 UTC) #20
jam
https://codereview.chromium.org/2925903004/diff/20001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/2925903004/diff/20001/content/renderer/render_thread_impl.cc#newcode1088 content/renderer/render_thread_impl.cc:1088: if (!renderer_host_.get()) { On 2017/06/06 23:05:46, dcheng wrote: > ...
3 years, 6 months ago (2017-06-07 03:32:41 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/188f19f9e26e879ac7aab7ac4bc54ba8cc57eb91
3 years, 6 months ago (2017-06-07 03:56:36 UTC) #24
kinuko
3 years, 6 months ago (2017-06-07 04:58:35 UTC) #26
Message was sent while issue was closed.
https://codereview.chromium.org/2925903004/diff/40001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2925903004/diff/40001/content/renderer/render...
content/renderer/render_frame_impl.cc:4313: // TODO: generalize how non-network
schemes are sent to the renderer and used.
Filed a bug- crbug.com/730338

Powered by Google App Engine
This is Rietveld 408576698