Issue 2925893002: [Merge to M60] Fix crash of update-over-cellular icon

Issue 2925893002: [Merge to M60] Fix crash of update-over-cellular icon (Closed)

Created:
3 years, 6 months ago by afakhry

Modified:
3 years, 6 months ago

Reviewers:
xiyuan, stevenjb, weidongg

CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

[Merge to M60] Fix crash of update-over-cellular icon The CL disables update-over-cellular icon in system tray in locked and login screen, as the icon will bring user to settings page which is not available yet. TBR=xiyuan@chromium.org,stevenjb@chromium.org,weidongg@chromium.org BUG=729202 Review-Url: https://codereview.chromium.org/2915383002 Cr-Original-Commit-Position: refs/heads/master@{#477015} Review-Url: https://codereview.chromium.org/2925893002 . Cr-Commit-Position: refs/branch-heads/3112@{#195} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/b5174f6d433bd20a07816d681d16af69cca3581c

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	ash/system/update/tray_update.cc	View		3 chunks	+7 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/upgrade_detector_chromeos.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

afakhry

3 years, 6 months ago (2017-06-06 18:40:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b5174f6d433bd20a07816d681d16af69cca3581c (presubmit successful).