Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2925843002: Add TaskTraits hints to AssertIO/WaitAllowed messages. (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
fdoray
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TaskTraits hints to AssertIO/WaitAllowed messages. To avoid many developers having to figure this out on their own, e.g. https://crbug.com/552552#c20 BUG=553459 Review-Url: https://codereview.chromium.org/2925843002 Cr-Commit-Position: refs/heads/master@{#477313} Committed: https://chromium.googlesource.com/chromium/src/+/92194f22fe5fa84643d10453040c85e228efe38f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M base/threading/thread_restrictions.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
gab
Francois PTaL and CQ
3 years, 6 months ago (2017-06-06 13:38:37 UTC) #4
fdoray
lgtm
3 years, 6 months ago (2017-06-06 17:10:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925843002/1
3 years, 6 months ago (2017-06-06 17:10:48 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 17:23:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92194f22fe5fa84643d10453040c...

Powered by Google App Engine
This is Rietveld 408576698