Use Fasta scanner when running analyzer.

Use Fasta scanner when running analyzer.

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/74b037fbf9c0cdea1341129063c1adea60201728

[ahe, 2017-06-06 11:53:08]

Patchset #1 (id:1) has been deleted

[ahe, 2017-06-06 11:55:35]

ahe@google.com changed reviewers:
+ danrubel@google.com, johnniwinther@google.com

[ahe, 2017-06-06 11:55:36]

Removing "-c" option makes the analyzer 40% faster (not surprising).

However, using the Fasta scanner seems to make the analyzer about 2% slower?

Have we regressed scanner performance, or performance of something else?

[danrubel, 2017-06-06 12:17:53]

LGTM

On 2017/06/06 11:55:36, ahe wrote:
> However, using the Fasta scanner seems to make the analyzer about 2% slower?

Good to know. Have not profiled this, but will put it on my list to investigate.

https://codereview.chromium.org/2925823002/diff/20001/pkg/testing/lib/src/ana...
File pkg/testing/lib/src/analyze.dart (right):

https://codereview.chromium.org/2925823002/diff/20001/pkg/testing/lib/src/ana...
pkg/testing/lib/src/analyze.dart:227: dartArguments
copy before modifying?

[ahe, 2017-06-06 12:37:46]

Thank you, Dan!

https://codereview.chromium.org/2925823002/diff/20001/pkg/testing/lib/src/ana...
File pkg/testing/lib/src/analyze.dart (right):

https://codereview.chromium.org/2925823002/diff/20001/pkg/testing/lib/src/ana...
pkg/testing/lib/src/analyze.dart:227: dartArguments
On 2017/06/06 12:17:53, danrubel wrote:
> copy before modifying?

Good point, but that's already taken care of, this is the documentation of
dartArguments:

/// Common arguments when running a dart program. Returns a copy that can
/// safely be modified by caller.

[danrubel, 2017-06-06 13:13:28]

On 2017/06/06 12:37:46, ahe wrote:
> Thank you, Dan!
> 
>
https://codereview.chromium.org/2925823002/diff/20001/pkg/testing/lib/src/ana...
> File pkg/testing/lib/src/analyze.dart (right):
> 
>
https://codereview.chromium.org/2925823002/diff/20001/pkg/testing/lib/src/ana...
> pkg/testing/lib/src/analyze.dart:227: dartArguments
> On 2017/06/06 12:17:53, danrubel wrote:
> > copy before modifying?
> 
> Good point, but that's already taken care of, this is the documentation of
> dartArguments:
> 
> /// Common arguments when running a dart program. Returns a copy that can
> /// safely be modified by caller.

Good to know. LGTM!

[ahe, 2017-06-06 18:06:47]

Description was changed from

==========
Use Fasta scanner when running analyzer.
==========

to

==========
Use Fasta scanner when running analyzer.

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/74b037fbf9c0cdea1341129063c1adea60201728
==========

[ahe, 2017-06-06 18:06:49]

Committed patchset #1 (id:20001) manually as
74b037fbf9c0cdea1341129063c1adea60201728 (presubmit successful).