Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2925823002: Use Fasta scanner when running analyzer. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/testing/lib/src/discover.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/analyze.dart
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
index 7f053e2c6feca8d8387f8f9e4b2b6799292d061d..af328f7aeaccc3ea6417b30b1be8346c192c64bc 100644
--- a/pkg/testing/lib/src/analyze.dart
+++ b/pkg/testing/lib/src/analyze.dart
@@ -11,7 +11,7 @@ import 'dart:convert' show LineSplitter, UTF8;
import 'dart:io'
show Directory, File, FileSystemEntity, Platform, Process, ProcessResult;
-import '../testing.dart' show startDart;
+import '../testing.dart' show dartArguments, startDart;
import 'log.dart' show isVerbose, splitLines;
@@ -221,7 +221,12 @@ Future<Null> analyzeUris(
print("Running dartanalyzer.");
}
Stopwatch sw = new Stopwatch()..start();
- Process process = await startDart(analyzer, const <String>["--batch"]);
+ Process process = await startDart(
+ analyzer,
+ const <String>["--batch"],
+ dartArguments
danrubel 2017/06/06 12:17:53 copy before modifying?
ahe 2017/06/06 12:37:46 Good point, but that's already taken care of, this
+ ..remove("-c")
+ ..add("-DuseFastaScanner=true"));
process.stdin.writeln(arguments.join(" "));
process.stdin.close();
« no previous file with comments | « no previous file | pkg/testing/lib/src/discover.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698