Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2925793002: [turbofan] Try harder to avoid write barriers when writing Smis. (Closed)

Created:
3 years, 6 months ago by Jarin
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Try harder to avoid write barriers when writing Smis. This avoids write barrier when writing smis to tagged fields. This includes writing to contexts, see example below: var f = (function() { var i = 0; return function f() { return i++; // Write barrier when writing to context. } })(); f(); f(); %OptimizeFunctionOnNextCall(f); f(); Review-Url: https://codereview.chromium.org/2925793002 Cr-Commit-Position: refs/heads/master@{#45723} Committed: https://chromium.googlesource.com/v8/v8/+/c22ca7f73ba92f22d0cd29b06bb2944a545a8d3e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 chunks +30 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Jarin
Could you take a look, please?
3 years, 6 months ago (2017-06-06 09:55:57 UTC) #4
Benedikt Meurer
LGTM modulo nit. https://codereview.chromium.org/2925793002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2925793002/diff/1/src/compiler/simplified-lowering.cc#newcode2486 src/compiler/simplified-lowering.cc:2486: access.type, input_info->representation(), node->InputAt(1)); Please give the ...
3 years, 6 months ago (2017-06-06 10:32:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925793002/20001
3 years, 6 months ago (2017-06-06 10:37:10 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 11:05:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c22ca7f73ba92f22d0cd29b06bb2944a545...

Powered by Google App Engine
This is Rietveld 408576698