Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: remoting/host/it2me/it2me_host_unittest.cc

Issue 2925733003: Report signling errors for register-support-host requests. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/it2me/it2me_host_unittest.cc
diff --git a/remoting/host/it2me/it2me_host_unittest.cc b/remoting/host/it2me/it2me_host_unittest.cc
index c00accce86e721ec5b603ef3dd9dc7347ce08bc5..068af645615a04ebf595af4db9ff33728ab69fcd 100644
--- a/remoting/host/it2me/it2me_host_unittest.cc
+++ b/remoting/host/it2me/it2me_host_unittest.cc
@@ -176,6 +176,7 @@ class It2MeHostTest : public testing::Test, public It2MeHost::Observer {
std::unique_ptr<base::MessageLoop> message_loop_;
std::unique_ptr<base::RunLoop> run_loop_;
+ std::unique_ptr<FakeSignalStrategy> fake_client_signal_strategy_;
scoped_refptr<AutoThreadTaskRunner> network_task_runner_;
scoped_refptr<AutoThreadTaskRunner> ui_task_runner_;
@@ -207,12 +208,16 @@ void It2MeHostTest::SetUp() {
std::unique_ptr<FakeIt2MeDialogFactory> dialog_factory(
new FakeIt2MeDialogFactory());
dialog_factory_ = dialog_factory.get();
- it2me_host_ = new It2MeHost(
- std::move(host_context),
- std::move(dialog_factory), weak_factory_.GetWeakPtr(),
- base::WrapUnique(
- new FakeSignalStrategy(SignalingAddress("fake_local_jid"))),
- kTestUserName, "fake_bot_jid");
+ fake_client_signal_strategy_.reset(
+ new FakeSignalStrategy(SignalingAddress("fake_client_jid")));
+ auto fake_signal_strategy =
+ base::MakeUnique<FakeSignalStrategy>(SignalingAddress("fake_local_jid"));
+ fake_client_signal_strategy_->ConnectTo(fake_signal_strategy.get());
kelvinp 2017/06/06 01:03:54 Since now we report signaling errors properly, we
+
+ it2me_host_ =
+ new It2MeHost(std::move(host_context), std::move(dialog_factory),
+ weak_factory_.GetWeakPtr(), std::move(fake_signal_strategy),
+ kTestUserName, "fake_bot_jid");
it2me_host_->OnPolicyUpdate(PolicyWatcher::GetDefaultPolicies());
}
« no previous file with comments | « no previous file | remoting/host/register_support_host_request.cc » ('j') | remoting/host/register_support_host_request.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698