Report signling errors for register-support-host requests.

remoting/host/it2me/it2me_host_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/it2me/it2me_host.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 
@@ skipping 158 matching lines @@
   // Used to set ConfirmationDialog behavior.
   FakeIt2MeDialogFactory* dialog_factory_ = nullptr;
 
   scoped_refptr<It2MeHost> it2me_host_;
 
  private:
   void StartupHostStateHelper(const base::Closure& quit_closure);
 
   std::unique_ptr<base::MessageLoop> message_loop_;
   std::unique_ptr<base::RunLoop> run_loop_;
+  std::unique_ptr<FakeSignalStrategy> fake_client_signal_strategy_;
 
   scoped_refptr<AutoThreadTaskRunner> network_task_runner_;
   scoped_refptr<AutoThreadTaskRunner> ui_task_runner_;
 
   base::WeakPtrFactory<It2MeHostTest> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(It2MeHostTest);
 };
 
 It2MeHostTest::It2MeHostTest() : weak_factory_(this) {}
@@ skipping 11 matching lines @@
 
   std::unique_ptr<ChromotingHostContext> host_context(
       ChromotingHostContext::Create(new AutoThreadTaskRunner(
           base::ThreadTaskRunnerHandle::Get(), run_loop_->QuitClosure())));
   network_task_runner_ = host_context->network_task_runner();
   ui_task_runner_ = host_context->ui_task_runner();
 
   std::unique_ptr<FakeIt2MeDialogFactory> dialog_factory(
       new FakeIt2MeDialogFactory());
   dialog_factory_ = dialog_factory.get();
-  it2me_host_ = new It2MeHost(
-      std::move(host_context),
-      std::move(dialog_factory), weak_factory_.GetWeakPtr(),
-      base::WrapUnique(
-          new FakeSignalStrategy(SignalingAddress("fake_local_jid"))),
-      kTestUserName, "fake_bot_jid");
+  fake_client_signal_strategy_.reset(
+      new FakeSignalStrategy(SignalingAddress("fake_client_jid")));
+  auto fake_signal_strategy =
+      base::MakeUnique<FakeSignalStrategy>(SignalingAddress("fake_local_jid"));
+  fake_client_signal_strategy_->ConnectTo(fake_signal_strategy.get());

[kelvinp, 2017/06/06 01:03:54]

Since now we report signaling errors properly, we would need to ensure the
signaling channel is connected or else StartHost() would fail with
SIGNALING_ERROR.

+
+  it2me_host_ =
+      new It2MeHost(std::move(host_context), std::move(dialog_factory),
+                    weak_factory_.GetWeakPtr(), std::move(fake_signal_strategy),
+                    kTestUserName, "fake_bot_jid");
 
   it2me_host_->OnPolicyUpdate(PolicyWatcher::GetDefaultPolicies());
 }
 
 void It2MeHostTest::TearDown() {
   // Shutdown the host if it hasn't been already. Without this, the call to
   // run_loop_->Run() may never return.
   it2me_host_->Disconnect();
   network_task_runner_ = nullptr;
   ui_task_runner_ = nullptr;
@@ skipping 329 matching lines @@
   ASSERT_EQ(ValidationResult::SUCCESS, validation_result_);
   ASSERT_EQ(It2MeHostState::kConnecting, last_host_state_);
 
   RunValidationCallback(kTestClientJid2);
   ASSERT_EQ(ValidationResult::ERROR_TOO_MANY_CONNECTIONS, validation_result_);
   RunUntilStateChanged(It2MeHostState::kDisconnected);
   ASSERT_EQ(It2MeHostState::kDisconnected, last_host_state_);
 }
 
 }  // namespace remoting