content/renderer/media/android/webmediaplayer_android.cc - Issue 292573004: Don't use webmediaplayer to FullscreenController about fullscreen change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 292573004: Don't use webmediaplayer to FullscreenController about fullscreen change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: removing content switch Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_web_contents_delegate.cc ('K') | « content/browser/media/android/browser_media_player_manager.cc ('k') | content/renderer/web_preferences.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/webmediaplayer_android.cc

diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc

index e9222a455a78a0a838ee7f02ad73e5a5f1ac7f1c..b1ba4d5735a25cfd298a852403ed556bc1f44e71 100644

--- a/content/renderer/media/android/webmediaplayer_android.cc

+++ b/content/renderer/media/android/webmediaplayer_android.cc

@@ -761,11 +761,8 @@ void WebMediaPlayerAndroid::OnDisconnectedFromRemoteDevice() {

}

void WebMediaPlayerAndroid::OnDidEnterFullscreen() {

- if (!manager_->IsInFullscreen(frame_)) {

- frame_->view()->willEnterFullScreen();

- frame_->view()->didEnterFullScreen();

+ if (!manager_->IsInFullscreen(frame_))

manager_->DidEnterFullscreen(frame_);

- }

}

void WebMediaPlayerAndroid::OnDidExitFullscreen() {

@@ -782,8 +779,6 @@ void WebMediaPlayerAndroid::OnDidExitFullscreen() {

manager_->RequestExternalSurface(player_id_, last_computed_rect_);

#endif // defined(VIDEO_HOLE)

- frame_->view()->willExitFullScreen();

- frame_->view()->didExitFullScreen();

manager_->DidExitFullscreen();

client_->repaint();

}