content/browser/media/android/browser_media_player_manager.cc - Issue 292573004: Don't use webmediaplayer to FullscreenController about fullscreen change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 292573004: Don't use webmediaplayer to FullscreenController about fullscreen change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: removing the fullscreenchanged IPC Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_web_contents_delegate.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | content/public/browser/render_view_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/android/browser_media_player_manager.cc

diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc

index c2e4df657449fde05e06dee1334eb452f310cbb7..feefc58f01245aac00431b6b025ac65cb12d8492 100644

--- a/content/browser/media/android/browser_media_player_manager.cc

+++ b/content/browser/media/android/browser_media_player_manager.cc

@@ -160,10 +160,10 @@ void BrowserMediaPlayerManager::FullscreenPlayerSeek(int msec) {

}

void BrowserMediaPlayerManager::ExitFullscreen(bool release_media_player) {

+ if (WebContentsDelegate* delegate = web_contents_->GetDelegate())

+ delegate->ToggleFullscreenModeForTab(web_contents_, false);

if (!CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisableOverlayFullscreenVideoSubtitle)) {

- if (WebContentsDelegate* delegate = web_contents_->GetDelegate())

- delegate->ToggleFullscreenModeForTab(web_contents_, false);

if (RenderWidgetHostViewAndroid* view_android =

static_cast<RenderWidgetHostViewAndroid*>(

web_contents_->GetRenderWidgetHostView())) {

@@ -211,8 +211,6 @@ void BrowserMediaPlayerManager::SetVideoSurface(

web_contents_->GetRenderWidgetHostView())) {

view_android->SetOverlayVideoMode(true);

}

- if (WebContentsDelegate* delegate = web_contents_->GetDelegate())

- delegate->ToggleFullscreenModeForTab(web_contents_, true);

}

void BrowserMediaPlayerManager::OnMediaMetadataChanged(