components/safe_browsing/csd.proto - Issue 2925693003: Making CSD ReportType enum consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing/csd.proto

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing/csd.proto

diff --git a/components/safe_browsing/csd.proto b/components/safe_browsing/csd.proto

index 8d8b4158c78d31391c3f338eb1f3093e15e529a5..d84cc15a9ee5b376e64b53056c042ef23c760f24 100644

--- a/components/safe_browsing/csd.proto

+++ b/components/safe_browsing/csd.proto

@@ -903,12 +903,12 @@ message ClientSafeBrowsingReportRequest {

URL_PHISHING = 1;

URL_MALWARE = 2;

URL_UNWANTED = 3;

- CLIENT_SIDE_PHISHING_URL = 4;

- CLIENT_SIDE_MALWARE_URL = 5;

+ URL_CLIENT_SIDE_PHISHING = 4;

+ URL_CLIENT_SIDE_MALWARE = 5;

DANGEROUS_DOWNLOAD_RECOVERY = 6;

DANGEROUS_DOWNLOAD_WARNING = 7;

DANGEROUS_DOWNLOAD_BY_API = 10;

- PASSWORD_PROTECTION_PHISHING_URL = 12;

+ URL_PASSWORD_PROTECTION_PHISHING = 12;

}

message HTTPHeader {