Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: components/safe_browsing/base_ping_manager_unittest.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)
Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/base_ping_manager.cc ('k') | components/safe_browsing/browser/threat_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/base_ping_manager_unittest.cc
diff --git a/components/safe_browsing/base_ping_manager_unittest.cc b/components/safe_browsing/base_ping_manager_unittest.cc
index 467611af9aed32545fc01702acfbbb4a4983a6f3..f65676e3ef88613bef1afc0799440056e6f571dc 100644
--- a/components/safe_browsing/base_ping_manager_unittest.cc
+++ b/components/safe_browsing/base_ping_manager_unittest.cc
@@ -125,7 +125,7 @@ TEST_F(BasePingManagerTest, TestSafeBrowsingHitUrl) {
{
HitReport hp(base_hp);
- hp.threat_type = SB_THREAT_TYPE_BINARY_MALWARE_URL;
+ hp.threat_type = SB_THREAT_TYPE_URL_BINARY_MALWARE;
hp.threat_source = ThreatSource::REMOTE;
hp.extended_reporting_level = SBER_LEVEL_OFF;
hp.is_metrics_reporting_active = true;
@@ -143,7 +143,7 @@ TEST_F(BasePingManagerTest, TestSafeBrowsingHitUrl) {
{
HitReport hp(base_hp);
- hp.threat_type = SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL;
+ hp.threat_type = SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING;
hp.threat_source = ThreatSource::LOCAL_PVER4;
hp.extended_reporting_level = SBER_LEVEL_OFF;
hp.is_metrics_reporting_active = false;
@@ -161,7 +161,7 @@ TEST_F(BasePingManagerTest, TestSafeBrowsingHitUrl) {
{
HitReport hp(base_hp);
- hp.threat_type = SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL;
+ hp.threat_type = SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE;
hp.threat_source = ThreatSource::LOCAL_PVER4;
hp.extended_reporting_level = SBER_LEVEL_OFF;
hp.is_metrics_reporting_active = false;
@@ -180,7 +180,7 @@ TEST_F(BasePingManagerTest, TestSafeBrowsingHitUrl) {
// Same as above, but add population_id
{
HitReport hp(base_hp);
- hp.threat_type = SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL;
+ hp.threat_type = SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE;
hp.threat_source = ThreatSource::LOCAL_PVER4;
hp.extended_reporting_level = SBER_LEVEL_OFF;
hp.is_metrics_reporting_active = false;
@@ -270,7 +270,7 @@ TEST_F(BasePingManagerTest, TestReportSafeBrowsingHit) {
hp.malicious_url = GURL("http://malicious.url.com");
hp.page_url = GURL("http://page.url.com");
hp.referrer_url = GURL("http://referrer.url.com");
- hp.threat_type = SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL;
+ hp.threat_type = SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE;
hp.threat_source = ThreatSource::LOCAL_PVER4;
hp.extended_reporting_level = SBER_LEVEL_OFF;
hp.is_metrics_reporting_active = false;
« no previous file with comments | « components/safe_browsing/base_ping_manager.cc ('k') | components/safe_browsing/browser/threat_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698