Call reload when user initiate reload using the omnibox

ios/chrome/browser/ui/browser_view_controller.mm

Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index ef6384d90059af5292aeafef2c81191fd5871596..81119c79aeaaf611c2d793f685663cb4f7c2829b 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -3762,6 +3762,15 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
     return;
   }
 
+  // If this is a reload initiated from the omnibox.
+  // TODO(crbug.com/730192): Add DCHECK to verify that whenever urlToLood is the

[marq (ping after 24h), 2017/06/08 09:16:25]

Rather than leave this hanging as a bug, can you just add the DCHECK on line
3768? It's just:

DCHECK(urlToLoad == [_model currentTab].lastCommitedURL)

right?

[mrefaat, 2017/06/08 17:01:57]

It's a todo as we are not 100% sure that this will be always the case, so i'll
go through the code around more before i decide how to proceed with that.

+  // same as the old url, the transition type is ui::PAGE_TRANSITION_RELOAD.
+  if (PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_RELOAD)) {
+    [[_model currentTab] navigationManager]->Reload(
+        web::ReloadType::NORMAL, true /* check_for_repost */);
+    return;
+  }
+
   web::NavigationManager::WebLoadParams params(urlToLoad);
   params.referrer = referrer;
   params.transition_type = transition;