Call reload when user initiate reload using the omnibox

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 3744 matching lines @@
   // load a disallowed URL, instead create a new tab not in the incognito state.
   if (_isOffTheRecord && !IsURLAllowedInIncognito(url)) {
     [self webPageOrderedOpen:url
                     referrer:web::Referrer()
                  inIncognito:NO
                 inBackground:NO
                     appendTo:kCurrentTab];
     return;
   }
 
+  // If this is a reload initiated from the omnibox.
+  // TODO(crbug.com/730192): Add DCHECK to verify that whenever urlToLood is the

[marq (ping after 24h), 2017/06/08 09:16:25]

Rather than leave this hanging as a bug, can you just add the DCHECK on line
3768? It's just:

DCHECK(urlToLoad == [_model currentTab].lastCommitedURL)

right?

[mrefaat, 2017/06/08 17:01:57]

It's a todo as we are not 100% sure that this will be always the case, so i'll
go through the code around more before i decide how to proceed with that.

+  // same as the old url, the transition type is ui::PAGE_TRANSITION_RELOAD.
+  if (PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_RELOAD)) {
+    [[_model currentTab] navigationManager]->Reload(
+        web::ReloadType::NORMAL, true /* check_for_repost */);
+    return;
+  }
+
   web::NavigationManager::WebLoadParams params(urlToLoad);
   params.referrer = referrer;
   params.transition_type = transition;
   params.is_renderer_initiated = rendererInitiated;
   DCHECK([_model currentTab]);
   [[_model currentTab] navigationManager]->LoadURLWithParams(params);
 }
 
 - (void)loadJavaScriptFromLocationBar:(NSString*)script {
   [_preloadController cancelPrerender];
@@ skipping 1406 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end