Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2925663004: Change format of data emitted in MemoryDumpProvider. (Closed)

Created:
3 years, 6 months ago by erikchen
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change format of data emitted in MemoryDumpProvider. This CL changes the data from a column per dispatcher type to a value per dispatcher type, which is easier to read and allows for integration with slow reports. BUG=705785 Review-Url: https://codereview.chromium.org/2925663004 Cr-Commit-Position: refs/heads/master@{#477469} Committed: https://chromium.googlesource.com/chromium/src/+/bf2cf91d6a8240cf080cceb53bc489cce7826c02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M mojo/edk/system/handle_table.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
erikchen
dskiba: Please review.
3 years, 6 months ago (2017-06-06 20:37:55 UTC) #3
DmitrySkiba
On 2017/06/06 20:37:55, erikchen wrote: > dskiba: Please review. LGTM, thanks! For whitelisting this for ...
3 years, 6 months ago (2017-06-06 23:43:57 UTC) #7
erikchen
rockot: Please review.
3 years, 6 months ago (2017-06-06 23:45:13 UTC) #9
Ken Rockot(use gerrit already)
RS LGTM
3 years, 6 months ago (2017-06-06 23:46:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925663004/1
3 years, 6 months ago (2017-06-06 23:50:12 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 23:54:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf2cf91d6a8240cf080cceb53bc4...

Powered by Google App Engine
This is Rietveld 408576698