Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2925643002: Add a path parsing policy handler for the RoamingProfileLocation policy. (Closed)

Created:
3 years, 6 months ago by pastarmovj
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Add a path parsing policy handler for the RoamingProfileLocation policy. This policy should like most other FilePath policies parse variables in its content before storing its value in its backing pref. BUG=726007 TEST=unit_tests Review-Url: https://codereview.chromium.org/2912353003 Cr-Original-Commit-Position: refs/heads/master@{#476272} Review-Url: https://codereview.chromium.org/2925643002 . Cr-Commit-Position: refs/branch-heads/3112@{#163} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/16cd06ee6d187017a7813e2e8801b5b4471507b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -3 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 3 chunks +2 lines, -3 lines 0 comments Download
A chrome/browser/policy/local_sync_policy_handler.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/policy/local_sync_policy_handler.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/policy/local_sync_policy_handler_unittest.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pastarmovj
3 years, 6 months ago (2017-06-05 18:37:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
16cd06ee6d187017a7813e2e8801b5b4471507b2.

Powered by Google App Engine
This is Rietveld 408576698