Add type inference for `this` expressions.

Add type inference for `this` expressions.

R=ahe@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/47d50e51a35cf432ef4bd3d0dee4380e1e312a00

[Paul Berry, 2017-06-05 17:34:54]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[Paul Berry, 2017-06-05 17:34:55]

Since this required some plumbing through fasta, I'd appreciate a review from
both Peter and Konstantin.

[scheglov, 2017-06-05 17:40:02]

LGTM

https://codereview.chromium.org/2925603002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart (right):

https://codereview.chromium.org/2925603002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart:77: field,
listener, field.enclosingClass?.thisType);
Nit: The order is not logical - it would be better to have listener, then the
enclosing type, then the field.

[Paul Berry, 2017-06-05 18:37:16]

https://codereview.chromium.org/2925603002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart (right):

https://codereview.chromium.org/2925603002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart:77: field,
listener, field.enclosingClass?.thisType);
On 2017/06/05 17:40:02, scheglov wrote:
> Nit: The order is not logical - it would be better to have listener, then the
> enclosing type, then the field.

Thanks.  Fixed.

[ahe, 2017-06-06 11:16:53]

lgtm

https://codereview.chromium.org/2925603002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2925603002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:408: if (parent is
ClassBuilder) {
How about:

if (builder.isClassMember) {
  Class cls = builder.parent.target;
  thisType = cls.thisType;
}

I'm assuming that it's intentional that you get this-type regardless of
builder.isInstanceMember, as that provides better error recovery. I'll take care
of reporting incorrect accesses to this anyways. Perhaps add a comment about
that?

[Paul Berry, 2017-06-06 16:50:33]

https://codereview.chromium.org/2925603002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2925603002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:408: if (parent is
ClassBuilder) {
On 2017/06/06 11:16:52, ahe wrote:
> How about:
> 
> if (builder.isClassMember) {
>   Class cls = builder.parent.target;
>   thisType = cls.thisType;
> }
> 
> I'm assuming that it's intentional that you get this-type regardless of
> builder.isInstanceMember, as that provides better error recovery. I'll take
care
> of reporting incorrect accesses to this anyways. Perhaps add a comment about
> that?

Done.

[Paul Berry, 2017-06-06 16:54:24]

Description was changed from

==========
Add type inference for `this` expressions.
==========

to

==========
Add type inference for `this` expressions.

R=ahe@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/47d50e51a35cf432ef4bd3d0dee4380e1e312a00
==========

[Paul Berry, 2017-06-06 16:54:26]

Committed patchset #2 (id:20001) manually as
47d50e51a35cf432ef4bd3d0dee4380e1e312a00 (presubmit successful).