Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

Issue 2925603002: Add type inference for `this` expressions. (Closed)
Patch Set: Address code review comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
index b03573cce8f5dd2a9cb3945c9e01b60d79e4f92e..15e7bc9f8b1de57d1620b8f346003dbf7bf8e1bd 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
@@ -8,7 +8,8 @@ import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart';
import 'package:front_end/src/fasta/type_inference/type_inference_listener.dart';
import 'package:front_end/src/fasta/type_inference/type_inferrer.dart';
import 'package:front_end/src/fasta/type_inference/type_schema_environment.dart';
-import 'package:kernel/ast.dart' show Class, DartType, DynamicType;
+import 'package:kernel/ast.dart'
+ show Class, DartType, DynamicType, InterfaceType;
import 'package:kernel/class_hierarchy.dart';
import 'package:kernel/core_types.dart';
@@ -49,12 +50,13 @@ abstract class TypeInferenceEngine {
/// Creates a type inferrer for use inside of a method body declared in a file
/// with the given [uri].
- TypeInferrer createLocalTypeInferrer(Uri uri, TypeInferenceListener listener);
+ TypeInferrer createLocalTypeInferrer(
+ Uri uri, TypeInferenceListener listener, InterfaceType thisType);
/// Creates a [TypeInferrer] object which is ready to perform type inference
/// on the given [field].
- TypeInferrer createTopLevelTypeInferrer(
- KernelField field, TypeInferenceListener listener);
+ TypeInferrer createTopLevelTypeInferrer(TypeInferenceListener listener,
+ InterfaceType thisType, KernelField field);
/// Performs the second phase of top level initializer inference, which is to
/// visit all fields and top level variables that were passed to [recordField]

Powered by Google App Engine
This is Rietveld 408576698