Move ScopedTokenPrivilege to chrome/installer/util

Move ScopedTokenPrivilege to chrome/installer/util

If the Chrome Cleaner requires a reboot of the machine to complete the
cleanup operation, Chrome will need to offer a reboot to the user. In
order to initiate a shutdown + restart, Chrome needs to acquire
SeShutdownPrivilege. The ScopedTokenPrivilege from
chrome/installer/setup/setup_util provides that functionality. This CL
moves it to chrome/installer/util where it can be used by both Chrome
and Setup.

BUG=728136
Review-Url: https://codereview.chromium.org/2925383002
Cr-Commit-Position: refs/heads/master@{#478357}
Committed: https://chromium.googlesource.com/chromium/src/+/524fdc6e30b5cdeb2f795abb5d571711bbdd75c6

[alito, 2017-06-08 23:43:33]

alito@chromium.org changed reviewers:
+ grt@chromium.org

[alito, 2017-06-08 23:43:33]

PTAL. This is a straight-forward move of the ScopedTokenPrivilege to a location
where both Chrome and Setup can use it. Let me know if there is a better placer
for this class.

[grt (UTC plus 2), 2017-06-09 08:35:28]

lgtm with some nits.

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
File chrome/installer/util/scoped_token_privilege.h (right):

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege.h:13: // This class is available
for Windows only and will enable the privilege
nit: put this in the "installer" namespace as it was before?

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
File chrome/installer/util/scoped_token_privilege_unittest.cc (right):

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege_unittest.cc:11: 
wrap this whole file in "namespace installer {"

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege_unittest.cc:17: static const
wchar_t kTestedPrivilege[] = SE_RESTORE_NAME;
no "static" in the unnamed namespace. please use "constexpr wchar_t ...[] =
...;" instead.

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege_unittest.cc:61: 
nit: close the unnamed namespace here -- i prefer having the tests themselves in
either a named namespace or none at all.

[alito, 2017-06-09 17:20:51]

All done. Thanks.

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
File chrome/installer/util/scoped_token_privilege.h (right):

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege.h:13: // This class is available
for Windows only and will enable the privilege
On 2017/06/09 08:35:28, grt (UTC plus 2) wrote:
> nit: put this in the "installer" namespace as it was before?

Done.

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
File chrome/installer/util/scoped_token_privilege_unittest.cc (right):

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege_unittest.cc:11: 
On 2017/06/09 08:35:28, grt (UTC plus 2) wrote:
> wrap this whole file in "namespace installer {"

Done.

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege_unittest.cc:17: static const
wchar_t kTestedPrivilege[] = SE_RESTORE_NAME;
On 2017/06/09 08:35:28, grt (UTC plus 2) wrote:
> no "static" in the unnamed namespace. please use "constexpr wchar_t ...[] =
> ...;" instead.

Done.

https://codereview.chromium.org/2925383002/diff/1/chrome/installer/util/scope...
chrome/installer/util/scoped_token_privilege_unittest.cc:61: 
On 2017/06/09 08:35:28, grt (UTC plus 2) wrote:
> nit: close the unnamed namespace here -- i prefer having the tests themselves
in
> either a named namespace or none at all.

Done.

[alito, 2017-06-09 17:21:01]

The CQ bit was checked by alito@chromium.org

[alito, 2017-06-09 17:21:02]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2925383002/#ps20001
(title: "Addressed Greg's comments.")

[commit-bot: I haz the power, 2017-06-09 17:21:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 18:56:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497028861853250,
"parent_rev": "6d116f3f194f67d1c7f318218861e308bf1cf769", "commit_rev":
"524fdc6e30b5cdeb2f795abb5d571711bbdd75c6"}

[commit-bot: I haz the power, 2017-06-09 18:56:31]

Description was changed from

==========
Move ScopedTokenPrivilege to chrome/installer/util

If the Chrome Cleaner requires a reboot of the machine to complete the
cleanup operation, Chrome will need to offer a reboot to the user. In
order to initiate a shutdown + restart, Chrome needs to acquire
SeShutdownPrivilege. The ScopedTokenPrivilege from
chrome/installer/setup/setup_util provides that functionality. This CL
moves it to chrome/installer/util where it can be used by both Chrome
and Setup.

BUG=728136
==========

to

==========
Move ScopedTokenPrivilege to chrome/installer/util

If the Chrome Cleaner requires a reboot of the machine to complete the
cleanup operation, Chrome will need to offer a reboot to the user. In
order to initiate a shutdown + restart, Chrome needs to acquire
SeShutdownPrivilege. The ScopedTokenPrivilege from
chrome/installer/setup/setup_util provides that functionality. This CL
moves it to chrome/installer/util where it can be used by both Chrome
and Setup.

BUG=728136

Review-Url: https://codereview.chromium.org/2925383002
Cr-Commit-Position: refs/heads/master@{#478357}
Committed:
https://chromium.googlesource.com/chromium/src/+/524fdc6e30b5cdeb2f795abb5d57...
==========

[commit-bot: I haz the power, 2017-06-09 18:56:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/524fdc6e30b5cdeb2f795abb5d57...