Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2925343003: Fix ThrottlingURLLoader to set task runner on Binding<URLLoaderClient>. (Closed)

Created:
3 years, 6 months ago by yzshen1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ThrottlingURLLoader to set task runner on Binding<URLLoaderClient>. The recent change of massively removing CreateInterfaceAndBind() incorrectly set the task runner on the URLLoaderClientPtr. This regressed loading performance. BUG=729769 Review-Url: https://codereview.chromium.org/2925343003 Cr-Commit-Position: refs/heads/master@{#478440} Committed: https://chromium.googlesource.com/chromium/src/+/511543cca3d300f35c0f1556cec42a95f634d1b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/throttling_url_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 6 months ago (2017-06-09 16:13:42 UTC) #4
Ken Rockot(use gerrit already)
lgtm
3 years, 6 months ago (2017-06-09 16:37:51 UTC) #6
jam
lgtm
3 years, 6 months ago (2017-06-09 22:45:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925343003/1
3 years, 6 months ago (2017-06-09 22:46:42 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 22:51:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/511543cca3d300f35c0f1556cec4...

Powered by Google App Engine
This is Rietveld 408576698