Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2925343002: Make WebUI MD login and lock screen default (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, rkc, Alexander Alekseev
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebUI MD login and lock screen default After this CL, use --show-non-md-login to go back to the original UI. Use --show-md-login to enable the views-based UI (WIP). BUG=718159 Review-Url: https://codereview.chromium.org/2925343002 Cr-Commit-Position: refs/heads/master@{#478111} Committed: https://chromium.googlesource.com/chromium/src/+/76b6fadab8f95b3e428dd3d373ec883a9df3b42e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 2 chunks +12 lines, -13 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Wenzhao (Colin) Zang
3 years, 6 months ago (2017-06-08 21:43:18 UTC) #3
jdufault
+rkc@ on cc. lgtm assuming you've tested all three cases.
3 years, 6 months ago (2017-06-08 22:01:39 UTC) #4
xiyuan
lgtm
3 years, 6 months ago (2017-06-08 22:05:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925343002/1
3 years, 6 months ago (2017-06-08 22:45:42 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 22:50:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76b6fadab8f95b3e428dd3d373ec...

Powered by Google App Engine
This is Rietveld 408576698