Update WebRtcVideoFrameAdapter to new buffer interface

Update WebRtcVideoFrameAdapter to new buffer interface

webrtc::VideoFrameBuffer can now support more than I420 and native
buffers, so the new VideoFrameBuffer::Type() function should be used to
determine what kind of buffer it is, and access to I420 data should be
done by first calling VideoFrameBuffer::ToI420(). The deprecated
functions in WebRtcVideoFrameAdapter will be removed eventually, but
this needs to happen in several steps synced with WebRTC CL:s in order
to not break anything in the process.

Another change with this CL is that WebRtcVideoFrameAdapter::ToI420()
can be called even if the frame is already in I420, it would previously
crash otherwise.

BUG=webrtc:7632
Review-Url: https://codereview.chromium.org/2925313002
Cr-Commit-Position: refs/heads/master@{#478516}
Committed: https://chromium.googlesource.com/chromium/src/+/74bf3d028824e0cb58519bd18839490f89bf7ac1

[magjed_chromium, 2017-06-08 19:27:09]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 19:27:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 21:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 21:41:36]

Dry run: This issue passed the CQ dry run.

[magjed_chromium, 2017-06-09 08:21:55]

Description was changed from

==========
.

BUG=
==========

to

==========
Update WebRtcVideoFrameAdapter to new buffer interface

BUG=webrtc:7632
==========

[magjed_chromium, 2017-06-09 08:33:04]

Description was changed from

==========
Update WebRtcVideoFrameAdapter to new buffer interface

BUG=webrtc:7632
==========

to

==========
Update WebRtcVideoFrameAdapter to new buffer interface

webrtc::VideoFrameBuffer can now support more than I420 and native
buffers, so the new VideoFrameBuffer::Type() function should be used to
determine what kind of buffer it is, and access to I420 data should be
done by first calling VideoFrameBuffer::ToI420(). The deprecated
functions in WebRtcVideoFrameAdapter will be removed eventually, but
this needs to happen in several steps synced with WebRTC CL:s in order
to not break anything in the process.

Another change with this CL is that WebRtcVideoFrameAdapter::ToI420()
can be called even if the frame is already in I420, it would previously
crash otherwise.

BUG=webrtc:7632
==========

[magjed_chromium, 2017-06-09 08:33:38]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 08:33:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[magjed_chromium, 2017-06-09 08:33:44]

Patchset #1 (id:1) has been deleted

[magjed_chromium, 2017-06-09 08:35:58]

magjed@chromium.org changed reviewers:
+ emircan@chromium.org

[magjed_chromium, 2017-06-09 08:36:22]

emircan - please take a look.

[commit-bot: I haz the power, 2017-06-09 09:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 09:45:17]

Dry run: This issue passed the CQ dry run.

[emircan, 2017-06-10 00:09:27]

lgtm % nit.

https://codereview.chromium.org/2925313002/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/webrtc_video_frame_adapter.cc (right):

https://codereview.chromium.org/2925313002/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/webrtc_video_frame_adapter.cc:118: if
(frame_->HasTextures()) {
DCHECK(media::VideoFrame::STORAGE_SHMEM == frame_->storage_type() ||
frame_->HasTextures());
This check would help if any unexpected type is ever used.

[magjed_chromium, 2017-06-10 15:45:01]

https://codereview.chromium.org/2925313002/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/webrtc_video_frame_adapter.cc (right):

https://codereview.chromium.org/2925313002/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/webrtc_video_frame_adapter.cc:118: if
(frame_->HasTextures()) {
On 2017/06/10 00:09:27, emircan wrote:
> DCHECK(media::VideoFrame::STORAGE_SHMEM == frame_->storage_type() ||
> frame_->HasTextures());
> This check would help if any unexpected type is ever used.

ToI420 is allowed to be called for any storage type, e.g. STORAGE_OWNED_MEMORY.
That's the reason I changed the implementation here. We only need to do
something in this function in the case of textures. IsValidFrame() should take
care of checking that it's a valid i420 frame after that, regardless of storage
type.

[magjed_chromium, 2017-06-10 15:45:08]

The CQ bit was checked by magjed@chromium.org

[commit-bot: I haz the power, 2017-06-10 15:45:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 16:49:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497109508782380,
"parent_rev": "6dcccd8c3f381d7127a3a3d83cf647daae594c97", "commit_rev":
"74bf3d028824e0cb58519bd18839490f89bf7ac1"}

[commit-bot: I haz the power, 2017-06-10 16:49:48]

Description was changed from

==========
Update WebRtcVideoFrameAdapter to new buffer interface

webrtc::VideoFrameBuffer can now support more than I420 and native
buffers, so the new VideoFrameBuffer::Type() function should be used to
determine what kind of buffer it is, and access to I420 data should be
done by first calling VideoFrameBuffer::ToI420(). The deprecated
functions in WebRtcVideoFrameAdapter will be removed eventually, but
this needs to happen in several steps synced with WebRTC CL:s in order
to not break anything in the process.

Another change with this CL is that WebRtcVideoFrameAdapter::ToI420()
can be called even if the frame is already in I420, it would previously
crash otherwise.

BUG=webrtc:7632
==========

to

==========
Update WebRtcVideoFrameAdapter to new buffer interface

webrtc::VideoFrameBuffer can now support more than I420 and native
buffers, so the new VideoFrameBuffer::Type() function should be used to
determine what kind of buffer it is, and access to I420 data should be
done by first calling VideoFrameBuffer::ToI420(). The deprecated
functions in WebRtcVideoFrameAdapter will be removed eventually, but
this needs to happen in several steps synced with WebRTC CL:s in order
to not break anything in the process.

Another change with this CL is that WebRtcVideoFrameAdapter::ToI420()
can be called even if the frame is already in I420, it would previously
crash otherwise.

BUG=webrtc:7632

Review-Url: https://codereview.chromium.org/2925313002
Cr-Commit-Position: refs/heads/master@{#478516}
Committed:
https://chromium.googlesource.com/chromium/src/+/74bf3d028824e0cb58519bd18839...
==========

[commit-bot: I haz the power, 2017-06-10 16:49:50]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74bf3d028824e0cb58519bd18839...