Enable DTLS caching for Android

Enable DTLS caching for Android.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229686

[jiayl, 2013-10-18 17:31:47]

PTAL.

Now CreateSelfSignedCert has been implemented for OPENSSL, we can enable DTLS
caching on Android.

[juberti2, 2013-10-18 18:31:24]

On 2013/10/18 17:31:47, jiayl wrote:
> PTAL.
> 
> Now CreateSelfSignedCert has been implemented for OPENSSL, we can enable DTLS
> caching on Android.

lgtm

[Ami GONE FROM CHROMIUM, 2013-10-18 18:33:14]

https://codereview.chromium.org/29253003/diff/1/content/renderer/media/peer_c...
File content/renderer/media/peer_connection_identity_service.cc (right):

https://codereview.chromium.org/29253003/diff/1/content/renderer/media/peer_c...
content/renderer/media/peer_connection_identity_service.cc:12:
PeerConnectionIdentityService* PeerConnectionIdentityService::Create(
This factory method is no longer necessary, so you can drop it and make the ctor
public.

[jiayl, 2013-10-18 22:13:42]

PTAL

https://codereview.chromium.org/29253003/diff/1/content/renderer/media/peer_c...
File content/renderer/media/peer_connection_identity_service.cc (right):

https://codereview.chromium.org/29253003/diff/1/content/renderer/media/peer_c...
content/renderer/media/peer_connection_identity_service.cc:12:
PeerConnectionIdentityService* PeerConnectionIdentityService::Create(
On 2013/10/18 18:33:14, Ami Fischman wrote:
> This factory method is no longer necessary, so you can drop it and make the
ctor
> public.

Done.

[Ami GONE FROM CHROMIUM, 2013-10-18 22:20:52]

LGTM

https://codereview.chromium.org/29253003/diff/80001/content/renderer/media/pe...
File content/renderer/media/peer_connection_identity_service.cc (left):

https://codereview.chromium.org/29253003/diff/80001/content/renderer/media/pe...
content/renderer/media/peer_connection_identity_service.cc:15: // OPENSSL yet
(crbug/91512). So returning NULL in that case.
Usually when you delete a crbug # in a CL that's a good sign you should add it
to the BUG= line of the CL description :)
But in this case 91512 looks kinda ambiguous; did it get silently fixed by a CL
that didn't point to it?
If yes, please add BUG=91512 to the CL description, add a pointer to the fixing
CL to the bug, and mark the bug closed.
If not, and this never really needed to wait for 91512, then please remove the
empty BUG= line from the CL description.

[jiayl, 2013-10-18 22:27:45]

On 2013/10/18 22:20:52, Ami Fischman wrote:
> LGTM
> 
>
https://codereview.chromium.org/29253003/diff/80001/content/renderer/media/pe...
> File content/renderer/media/peer_connection_identity_service.cc (left):
> 
>
https://codereview.chromium.org/29253003/diff/80001/content/renderer/media/pe...
> content/renderer/media/peer_connection_identity_service.cc:15: // OPENSSL yet
> (crbug/91512). So returning NULL in that case.
> Usually when you delete a crbug # in a CL that's a good sign you should add it
> to the BUG= line of the CL description :)
> But in this case 91512 looks kinda ambiguous; did it get silently fixed by a
CL
> that didn't point to it?
> If yes, please add BUG=91512 to the CL description, add a pointer to the
fixing
> CL to the bug, and mark the bug closed.
> If not, and this never really needed to wait for 91512, then please remove the
> empty BUG= line from the CL description.

OK, marked the bug fixed by r229305

[commit-bot: I haz the power, 2013-10-18 22:56:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiayl@chromium.org/29253003/80001

[commit-bot: I haz the power, 2013-10-20 08:19:35]

Change committed as 229686