Enable DTLS caching for Android

content/renderer/media/peer_connection_identity_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/peer_connection_identity_service.h"
 
 #include "content/renderer/media/webrtc_identity_service.h"
 #include "content/renderer/render_thread_impl.h"
 
 namespace content {
 
-PeerConnectionIdentityService* PeerConnectionIdentityService::Create(
-    const GURL& origin) {
-// The crypto APIs needed for generating identities are not implenented for
-// OPENSSL yet (crbug/91512). So returning NULL in that case.

[Ami GONE FROM CHROMIUM, 2013/10/18 22:20:52]

Usually when you delete a crbug # in a CL that's a good sign you should add it
to the BUG= line of the CL description :)
But in this case 91512 looks kinda ambiguous; did it get silently fixed by a CL
that didn't point to it?
If yes, please add BUG=91512 to the CL description, add a pointer to the fixing
CL to the bug, and mark the bug closed.
If not, and this never really needed to wait for 91512, then please remove the
empty BUG= line from the CL description.

-// TODO(jiayl): remove the #if once the crypto APIs are implemented for OPENSSL.
-#if defined(USE_OPENSSL)
-  return NULL;
-#else
-  return new PeerConnectionIdentityService(origin);
-#endif  // defined(USE_OPENSSL)
-}
+PeerConnectionIdentityService::PeerConnectionIdentityService(const GURL& origin)
+    : origin_(origin), pending_observer_(NULL), pending_request_id_(0) {}
 
 PeerConnectionIdentityService::~PeerConnectionIdentityService() {
   if (pending_observer_)
     RenderThreadImpl::current()->get_webrtc_identity_service()
         ->CancelRequest(pending_request_id_);
 }
 
 bool PeerConnectionIdentityService::RequestIdentity(
     const std::string& identity_name,
     const std::string& common_name,
     webrtc::DTLSIdentityRequestObserver* observer) {
   DCHECK(observer);
   if (pending_observer_)
     return false;
 
   pending_observer_ = observer;
   pending_request_id_ = RenderThreadImpl::current()
       ->get_webrtc_identity_service()->RequestIdentity(
           origin_,
           identity_name,
           common_name,
           base::Bind(&PeerConnectionIdentityService::OnIdentityReady,
                      base::Unretained(this)),
           base::Bind(&PeerConnectionIdentityService::OnRequestFailed,
                      base::Unretained(this)));
   return true;
 }
 
-PeerConnectionIdentityService::PeerConnectionIdentityService(const GURL& origin)
-    : origin_(origin), pending_observer_(NULL), pending_request_id_(0) {}
-
 void PeerConnectionIdentityService::OnIdentityReady(
     const std::string& certificate,
     const std::string& private_key) {
   pending_observer_->OnSuccess(certificate, private_key);
   ResetPendingRequest();
 }
 
 void PeerConnectionIdentityService::OnRequestFailed(int error) {
   pending_observer_->OnFailure(error);
   ResetPendingRequest();
 }
 
 void PeerConnectionIdentityService::ResetPendingRequest() {
   pending_observer_ = NULL;
   pending_request_id_ = 0;
 }
 
 }  // namespace content