Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2925273006:
suppress fragile test for binary skp (Closed)
Descriptionsuppress fragile test for binary skp
BUG=731731
NOTRY=True
Review-Url: https://codereview.chromium.org/2925273006
Cr-Commit-Position: refs/heads/master@{#478288}
Committed: https://chromium.googlesource.com/chromium/src/+/0bd38e83d4f360d2a1258d0eaa143de826f2062a
Patch Set 1 #
Total comments: 1
Patch Set 2 : fail or pass #Messages
Total messages: 20 (13 generated)
reed@google.com changed reviewers: + fmalita@chromium.org
needed to unblock roll
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reed@google.com changed reviewers: + robertphillips@chromium.org
Description was changed from ========== suppress fragile test for skps BUG= ========== to ========== suppress fragile test for skps BUG=731731 ==========
lgtm https://codereview.chromium.org/2925273006/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2925273006/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:1080: crbug.com/731731 inspector-protocol/layers/paint-profiler-load-empty.html [ Failure ] [ Failure Pass ] otherwise it may yield warnings (for passing) before the roll.
Description was changed from ========== suppress fragile test for skps BUG=731731 ========== to ========== suppress fragile test for binary skp BUG=731731 ==========
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/2925273006/#ps20001 (title: "fail or pass")
On 2017/06/09 15:18:18, f(malita) wrote: > lgtm > > https://codereview.chromium.org/2925273006/diff/1/third_party/WebKit/LayoutTe... > File third_party/WebKit/LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/2925273006/diff/1/third_party/WebKit/LayoutTe... > third_party/WebKit/LayoutTests/TestExpectations:1080: crbug.com/731731 > inspector-protocol/layers/paint-profiler-load-empty.html [ Failure ] > [ Failure Pass ] > > otherwise it may yield warnings (for passing) before the roll. Done
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== suppress fragile test for binary skp BUG=731731 ========== to ========== suppress fragile test for binary skp BUG=731731 NOTRY=True ==========
The CQ bit was unchecked by reed@google.com
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497022215707370,
"parent_rev": "810bd6f44ea3be0e7ff4522190cf2e4924769e17", "commit_rev":
"0bd38e83d4f360d2a1258d0eaa143de826f2062a"}
Message was sent while issue was closed.
Description was changed from ========== suppress fragile test for binary skp BUG=731731 NOTRY=True ========== to ========== suppress fragile test for binary skp BUG=731731 NOTRY=True Review-Url: https://codereview.chromium.org/2925273006 Cr-Commit-Position: refs/heads/master@{#478288} Committed: https://chromium.googlesource.com/chromium/src/+/0bd38e83d4f360d2a1258d0eaa14... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0bd38e83d4f360d2a1258d0eaa14... |
