Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 2925233002: Enable SafeBrowsing lookups for ws: and wss: URLs (Closed)

Created:
3 years, 6 months ago by Adam Rice
Modified:
3 years, 6 months ago
Reviewers:
elawrence, mattm
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable SafeBrowsing lookups for ws: and wss: URLs Modify the three "real" implementations of SafeBrowsingDatabaseManager to enable lookups for "ws:" and "wss:" URLs. This change doesn't cause SafeBrowsing checks to be performed on WebSocket URLs. No ws: or wss: URLs will be passed to the SafeBrowsingDatabaseManager yet. It just ensures that they will actually be looked up when a future change causes them to be checked. This change is required for both designs described in the "WebSocket SafeBrowsing Support" design document: https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJYPs/edit BUG=644744 Review-Url: https://codereview.chromium.org/2925233002 Cr-Commit-Position: refs/heads/master@{#478553} Committed: https://chromium.googlesource.com/chromium/src/+/52d6e906dd50c3710aa32af423ce6aa6661ec969

Patch Set 1 #

Patch Set 2 : Accidentally removed ftp: URLs. Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/safe_browsing/local_database_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/remote_database_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Adam Rice
3 years, 6 months ago (2017-06-08 09:29:40 UTC) #10
elawrence
On 2017/06/08 09:29:40, Adam Rice wrote: non-owner LGTM
3 years, 6 months ago (2017-06-08 14:27:26 UTC) #11
Adam Rice
On 2017/06/08 14:27:26, elawrence wrote: > non-owner LGTM Oops, should have checked the OWNERS file. ...
3 years, 6 months ago (2017-06-09 03:31:29 UTC) #12
Adam Rice
+mattm for OWNERS.
3 years, 6 months ago (2017-06-09 03:37:38 UTC) #13
Adam Rice
+mattm for real this time.
3 years, 6 months ago (2017-06-09 03:47:57 UTC) #15
mattm
lgtm
3 years, 6 months ago (2017-06-09 17:37:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925233002/20001
3 years, 6 months ago (2017-06-12 03:28:50 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 04:31:11 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/52d6e906dd50c3710aa32af423ce...

Powered by Google App Engine
This is Rietveld 408576698