Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2925213002: cc: Mark layers with invalid property tree indices as non-drawable. (Closed)

Created:
3 years, 6 months ago by Khushal
Modified:
3 years, 6 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Mark layers with invalid property tree indices as non-drawable. We already skip these layers during UpdateDrawProperties to prevent crashes. Mark these layers as non-drawing so they are skipped by the rest of the system. BUG=730020 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2925213002 Cr-Commit-Position: refs/heads/master@{#478657} Committed: https://chromium.googlesource.com/chromium/src/+/83bb2dde82e5e1ed714a09579faed14206377927

Patch Set 1 #

Patch Set 2 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/trees/draw_property_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Khushal
3 years, 6 months ago (2017-06-08 00:49:39 UTC) #3
Khushal
On 2017/06/08 00:49:39, Khushal wrote: ping. :)
3 years, 6 months ago (2017-06-09 21:31:52 UTC) #4
weiliangc
lgtm
3 years, 6 months ago (2017-06-12 15:17:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925213002/20001
3 years, 6 months ago (2017-06-12 15:17:54 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 16:32:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/83bb2dde82e5e1ed714a09579fae...

Powered by Google App Engine
This is Rietveld 408576698