Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2925203003: Add a test for Notification.permission. (Closed)

Created:
3 years, 6 months ago by dominickn
Modified:
3 years, 6 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, raymes
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for Notification.permission. This CL adds an interactive UI test for the window.Notification.permission API. In particular, it checks that the correct value is returned when the notifications permission has been embargoed due to multiple dismissals. BUG=730273 Review-Url: https://codereview.chromium.org/2925203003 Cr-Commit-Position: refs/heads/master@{#477920} Committed: https://chromium.googlesource.com/chromium/src/+/a970559340c9a67098bc9b722854a4bfaa014d27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M chrome/browser/notifications/notification_interactive_uitest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_interactive_uitest_support.h View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_interactive_uitest_support.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/test/data/notifications/notification_tester.html View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
dominickn
PTAL, thanks!
3 years, 6 months ago (2017-06-08 01:03:38 UTC) #4
Miguel Garcia
lgtm thanks!
3 years, 6 months ago (2017-06-08 06:49:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925203003/1
3 years, 6 months ago (2017-06-08 07:42:43 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 07:48:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a970559340c9a67098bc9b722854...

Powered by Google App Engine
This is Rietveld 408576698