Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: extensions/renderer/extension_frame_helper.cc

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/extension_frame_helper.cc
diff --git a/extensions/renderer/extension_frame_helper.cc b/extensions/renderer/extension_frame_helper.cc
index 6a91e015b28e65a673f9ba84220d35c67f76394c..1bffa4af3a26c9092ef60dfc4098421578c9c813 100644
--- a/extensions/renderer/extension_frame_helper.cc
+++ b/extensions/renderer/extension_frame_helper.cc
@@ -161,8 +161,31 @@ content::RenderFrame* ExtensionFrameHelper::FindFrame(
helper->render_frame()->GetWebFrame()->GetSecurityOrigin()))
continue;
- if (helper->render_frame()->GetWebFrame()->AssignedName().Utf8() == name)
+ if (helper->render_frame()->GetWebFrame()->AssignedName().Utf8() == name) {
+ UMA_HISTOGRAM_ENUMERATION(
+ "Extensions.BrowsingInstanceViolation.ExtensionViewType",
+ helper->view_type(), VIEW_TYPE_LAST);
+
+ GURL effective_target_url = ScriptContext::GetEffectiveDocumentURL(
+ helper->render_frame()->GetWebFrame(),
+ helper->render_frame()->GetWebFrame()->GetDocument().Url(), true);
+ const Extension* target_extension =
+ extensions::RendererExtensionRegistry::Get()->GetExtensionOrAppByURL(
+ effective_target_url);
+ UMA_HISTOGRAM_ENUMERATION(
+ "Extensions.BrowsingInstanceViolation.ExtensionType",
+ target_extension->GetType(), Manifest::TYPE_MAX);
+
+ // DO NOT SUBMIT - remove the ad-hoc logging before landing this CL. The
+ // log just shows that the UMA recording code is getting hit (despite
+ // seeing no samples via base::HistogramTester in the browser test).
+ LOG(ERROR) << "ExtensionFrameHelper::FindFrame"
+ << "; target_extension->GetType() = "
+ << target_extension->GetType()
+ << "; helper->view_type() = " << helper->view_type();
+
return helper->render_frame();
+ }
}
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698