NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

extensions/renderer/extension_frame_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/extension_frame_helper.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
 #include "base/timer/elapsed_timer.h"
 #include "content/public/renderer/render_frame.h"
@@ skipping 143 matching lines @@
           effective_url);
   if (!extension)
     return nullptr;
 
   // Try to match all same-origin frames in this process.
   for (const ExtensionFrameHelper* helper : g_frame_helpers.Get()) {
     if (!relative_to_frame->GetWebFrame()->GetSecurityOrigin().CanAccess(
             helper->render_frame()->GetWebFrame()->GetSecurityOrigin()))
       continue;
 
-    if (helper->render_frame()->GetWebFrame()->AssignedName().Utf8() == name)
+    if (helper->render_frame()->GetWebFrame()->AssignedName().Utf8() == name) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Extensions.BrowsingInstanceViolation.ExtensionViewType",
+          helper->view_type(), VIEW_TYPE_LAST);
+
+      GURL effective_target_url = ScriptContext::GetEffectiveDocumentURL(
+          helper->render_frame()->GetWebFrame(),
+          helper->render_frame()->GetWebFrame()->GetDocument().Url(), true);
+      const Extension* target_extension =
+          extensions::RendererExtensionRegistry::Get()->GetExtensionOrAppByURL(
+              effective_target_url);
+      UMA_HISTOGRAM_ENUMERATION(
+          "Extensions.BrowsingInstanceViolation.ExtensionType",
+          target_extension->GetType(), Manifest::TYPE_MAX);
+
+      // DO NOT SUBMIT - remove the ad-hoc logging before landing this CL.  The
+      // log just shows that the UMA recording code is getting hit (despite
+      // seeing no samples via base::HistogramTester in the browser test).
+      LOG(ERROR) << "ExtensionFrameHelper::FindFrame"
+                 << "; target_extension->GetType() = "
+                 << target_extension->GetType()
+                 << "; helper->view_type() = " << helper->view_type();
+
       return helper->render_frame();
+    }
   }
 
   return nullptr;
 }
 
 // static
 bool ExtensionFrameHelper::IsContextForEventPage(const ScriptContext* context) {
   content::RenderFrame* render_frame = context->GetRenderFrame();
   return context->extension() && render_frame &&
          BackgroundInfo::HasLazyBackgroundPage(context->extension()) &&
@@ skipping 182 matching lines @@
     const base::ListValue& args) {
   extension_dispatcher_->InvokeModuleSystemMethod(
       render_frame(), extension_id, module_name, function_name, args);
 }
 
 void ExtensionFrameHelper::OnDestruct() {
   delete this;
 }
 
 }  // namespace extensions