Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: extensions/common/manifest.h

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest.h
diff --git a/extensions/common/manifest.h b/extensions/common/manifest.h
index f21713ad7dd6aeb328d924557f4821b2d0b6e9c6..f6e3e3043bf5c2283d9d87c791e8dc8b46718e01 100644
--- a/extensions/common/manifest.h
+++ b/extensions/common/manifest.h
@@ -52,22 +52,22 @@ class Manifest {
NUM_LOCATIONS
};
- // Do not change the order of entries or remove entries in this list
- // as this is used in UMA_HISTOGRAM_ENUMERATIONs about extensions.
+ // Do not change the order of entries or remove entries in this list as this
+ // is used in ExtensionType enum in tools/metrics/histograms/enums.xml.
enum Type {
TYPE_UNKNOWN = 0,
- TYPE_EXTENSION,
- TYPE_THEME,
- TYPE_USER_SCRIPT,
- TYPE_HOSTED_APP,
+ TYPE_EXTENSION = 1,
+ TYPE_THEME = 2,
+ TYPE_USER_SCRIPT = 3,
+ TYPE_HOSTED_APP = 4,
// This is marked legacy because platform apps are preferred. For
// backwards compatibility, we can't remove support for packaged apps
- TYPE_LEGACY_PACKAGED_APP,
- TYPE_PLATFORM_APP,
- TYPE_SHARED_MODULE,
+ TYPE_LEGACY_PACKAGED_APP = 5,
+ TYPE_PLATFORM_APP = 6,
+ TYPE_SHARED_MODULE = 7,
// New enum values must go above here.
- NUM_LOAD_TYPES
+ TYPE_MAX = TYPE_SHARED_MODULE,
};
// Given two install sources, return the one which should take priority

Powered by Google App Engine
This is Rietveld 408576698