extensions/common/features/simple_feature.cc - Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/simple_feature.cc

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/simple_feature.cc

diff --git a/extensions/common/features/simple_feature.cc b/extensions/common/features/simple_feature.cc

index bb5aa6a829580c26b8d8902c971a31a2e23029e4..074cbe758cee994c9f00a4810042e624a850d92e 100644

--- a/extensions/common/features/simple_feature.cc

+++ b/extensions/common/features/simple_feature.cc

@@ -73,8 +73,6 @@ std::string GetDisplayName(Manifest::Type type) {

return "user script";

case Manifest::TYPE_SHARED_MODULE:

return "shared module";

- case Manifest::NUM_LOAD_TYPES:

- NOTREACHED();

}

NOTREACHED();

return "";