Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2925113004: Record the correct value for print job results. (Closed)

Created:
3 years, 6 months ago by skau
Modified:
3 years, 6 months ago
Reviewers:
Carlson, xdai1
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Record the correct value for print job results. During refactoring, the wrong value was recorded. Record the correct value. BUG=725740 Review-Url: https://codereview.chromium.org/2925113004 Cr-Commit-Position: refs/heads/master@{#478705} Committed: https://chromium.googlesource.com/chromium/src/+/8860a660e6bce2f1dde2686ae82efd742ba7ab5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
skau
Please review. I'm an idiot.
3 years, 6 months ago (2017-06-08 18:18:53 UTC) #2
Carlson
lgtm
3 years, 6 months ago (2017-06-12 18:03:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925113004/1
3 years, 6 months ago (2017-06-12 18:11:14 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-12 18:11:16 UTC) #7
skau
xdai@: Can you approve this for me?
3 years, 6 months ago (2017-06-12 18:13:43 UTC) #9
xdai1
Sure! lgtm
3 years, 6 months ago (2017-06-12 18:27:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925113004/1
3 years, 6 months ago (2017-06-12 18:37:16 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 19:04:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8860a660e6bce2f1dde2686ae82e...

Powered by Google App Engine
This is Rietveld 408576698