Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2924983002: Remove "named arguments" in domdistiller.js (Closed)

Created:
3 years, 6 months ago by wychen
Modified:
3 years, 6 months ago
Reviewers:
mdjones
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "named arguments" in domdistiller.js Unlike Python, there's no named arguments in JavaScript. Now this works in strict mode. The transpiled JavaScript in third_party/dom_distiller_js/dist/js/domdistiller.js still doesn't work in strict mode. BUG=728655 Review-Url: https://codereview.chromium.org/2924983002 Cr-Commit-Position: refs/heads/master@{#477508} Committed: https://chromium.googlesource.com/chromium/src/+/b24059c04caebfc2542f765a6064ccc5a6d1b27d

Patch Set 1 #

Total comments: 2

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/dom_distiller/core/javascript/domdistiller.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
wychen
PTAL
3 years, 6 months ago (2017-06-07 00:00:53 UTC) #3
mdjones
lgtm https://codereview.chromium.org/2924983002/diff/1/components/dom_distiller/core/javascript/domdistiller.js File components/dom_distiller/core/javascript/domdistiller.js (right): https://codereview.chromium.org/2924983002/diff/1/components/dom_distiller/core/javascript/domdistiller.js#newcode37 components/dom_distiller/core/javascript/domdistiller.js:37: $$STRINGIFY) nit: do these still need to be ...
3 years, 6 months ago (2017-06-07 00:15:44 UTC) #4
wychen
https://codereview.chromium.org/2924983002/diff/1/components/dom_distiller/core/javascript/domdistiller.js File components/dom_distiller/core/javascript/domdistiller.js (right): https://codereview.chromium.org/2924983002/diff/1/components/dom_distiller/core/javascript/domdistiller.js#newcode37 components/dom_distiller/core/javascript/domdistiller.js:37: $$STRINGIFY) On 2017/06/07 00:15:44, mdjones wrote: > nit: do ...
3 years, 6 months ago (2017-06-07 01:17:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924983002/20001
3 years, 6 months ago (2017-06-07 01:18:07 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 01:42:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b24059c04caebfc2542f765a6064...

Powered by Google App Engine
This is Rietveld 408576698