Break ConsentProvider classes into own file

Break ConsentProvider classes into own file

file_system_api.cc/h is large and has lots of dependencies. Split out
the Chrome OS UI-specific helper classes, ConsentProvider and
ConsentProviderDelegate, into consent_provider.cc/h.

Also moves the ConsentProvider unit tests into its own file.

BUG=729713
Review-Url: https://codereview.chromium.org/2924943003
Cr-Commit-Position: refs/heads/master@{#478337}
Committed: https://chromium.googlesource.com/chromium/src/+/c1c493275806565b74b5d4c75be682e001272c06

[michaelpg, 2017-06-07 06:28:03]

michaelpg@chromium.org changed reviewers:
+ benwells@chromium.org, mtomasz@chromium.org

[michaelpg, 2017-06-07 06:28:04]

mtomasz: PTAL for file_system.
benwells: for BUILD.gn

https://codereview.chromium.org/2924943003/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/consent_provider.cc (right):

https://codereview.chromium.org/2924943003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/consent_provider.cc:154:
content::WebContents* web_contents = nullptr;
This is the only logic I actually changed in this CL. I just didn't want to
duplicate the GetWebContentsForRenderFrameHost static method from
file_system_api.cc and this seems like equivalent and straightforward logic.

[mtomasz, 2017-06-07 06:34:54]

lgtm for my part

[benwells, 2017-06-07 07:48:51]

lgtm

[michaelpg, 2017-06-09 16:54:32]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-06-09 16:54:33]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/2924943003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-09 16:54:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 18:22:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497027272523310,
"parent_rev": "6495c08b5e99164f9dd91c651abcada2a381f72d", "commit_rev":
"c1c493275806565b74b5d4c75be682e001272c06"}

[commit-bot: I haz the power, 2017-06-09 18:22:50]

Description was changed from

==========
Break ConsentProvider classes into own file

file_system_api.cc/h is large and has lots of dependencies. Split out
the Chrome OS UI-specific helper classes, ConsentProvider and
ConsentProviderDelegate, into consent_provider.cc/h.

Also moves the ConsentProvider unit tests into its own file.

BUG=729713
==========

to

==========
Break ConsentProvider classes into own file

file_system_api.cc/h is large and has lots of dependencies. Split out
the Chrome OS UI-specific helper classes, ConsentProvider and
ConsentProviderDelegate, into consent_provider.cc/h.

Also moves the ConsentProvider unit tests into its own file.

BUG=729713

Review-Url: https://codereview.chromium.org/2924943003
Cr-Commit-Position: refs/heads/master@{#478337}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1c493275806565b74b5d4c75be6...
==========

[commit-bot: I haz the power, 2017-06-09 18:22:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c1c493275806565b74b5d4c75be6...