Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924913002: NetInfo network quality extension: Add callbacks and Layout tests (Closed)

Created:
3 years, 6 months ago by tbansal1
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, nessy, pfeldman+blink_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, haraken, feature-media-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, Srirama, lushnikov+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

NetInfo network quality extension: Add callbacks and Layout tests "change" event is fired from NetworkInformation.cpp when there is a change in the network quality. Also, layout tests have been added for the network quality extension to the NetInfo API. BUG=725282, 726762 Review-Url: https://codereview.chromium.org/2903493002 Cr-Original-Commit-Position: refs/heads/master@{#476595} Review-Url: https://codereview.chromium.org/2924913002 . Cr-Commit-Position: refs/branch-heads/3112@{#204} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/52551041771eca1ec73306e43c9ad370b7131887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/basic-operation.html View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/basic-operation-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html View 1 chunk +10 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt View 1 chunk +8 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames.html View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/netinfo/estimate-web-worker.html View 1 chunk +9 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/netinfo/estimate-web-worker-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/netinfo/network-quality.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/netinfo/network-quality-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/resources/web-worker.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/type-change-no-listener-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/unregister-during-event-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/netinfo/web-worker.html View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +29 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp View 1 chunk +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkStateNotifier.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp View 2 chunks +24 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp View 3 chunks +88 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
3 years, 6 months ago (2017-06-06 20:20:37 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
52551041771eca1ec73306e43c9ad370b7131887.

Powered by Google App Engine
This is Rietveld 408576698