Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2924903003: Enable multiple touch in WebView. (Closed)

Created:
3 years, 6 months ago by michaeldo
Modified:
3 years, 6 months ago
Reviewers:
jif
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable multiple touch in WebView. WebView touches are aggressively disabled by the overscroll_actions_controller once a single touch begins to move. This seems unnecessary and it breaks multi-touch within the webView. TEST=See bug for replication steps to test multitouch. Also ensure overscroll actions perform as expected, ensure that user interaction with the webpage does not occur while the overscroll actions are visible. Ex: Pull to refresh. BUG=715120 Review-Url: https://codereview.chromium.org/2924903003 Cr-Commit-Position: refs/heads/master@{#478298} Committed: https://chromium.googlesource.com/chromium/src/+/feecd1919ed0b1e35e8262f540cf884e8719adc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
michaeldo
PTAL. I'm not sure if this is the best way to handle it as I ...
3 years, 6 months ago (2017-06-06 21:50:54 UTC) #2
jif
Didn't notice anything wrong either. lgtm
3 years, 6 months ago (2017-06-09 12:24:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924903003/1
3 years, 6 months ago (2017-06-09 15:56:43 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 16:12:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/feecd1919ed0b1e35e8262f540cf...

Powered by Google App Engine
This is Rietveld 408576698