Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2924883002: DevTools: migrate SSP Classes and ElementState toolbar widgets to shadow (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate SSP Classes and ElementState toolbar widgets to shadow BUG=726972 Review-Url: https://codereview.chromium.org/2924883002 Cr-Commit-Position: refs/heads/master@{#477832} Committed: https://chromium.googlesource.com/chromium/src/+/ffbe0338c8f8acba7ec54e90d821049c341266ea

Patch Set 1 #

Total comments: 1

Messages

Total messages: 8 (4 generated)
luoe
Please take a look. Besides the comment about merging two rulesets, the rest is mechanical. ...
3 years, 6 months ago (2017-06-06 18:38:17 UTC) #2
pfeldman
lgtm
3 years, 6 months ago (2017-06-07 21:44:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924883002/1
3 years, 6 months ago (2017-06-07 22:24:41 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:37:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffbe0338c8f8acba7ec54e90d821...

Powered by Google App Engine
This is Rietveld 408576698