Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2924873008: [M60] exo: Fix multi-display hardware cursor (Closed)

Created:
3 years, 6 months ago by Dominik Laskowski
Modified:
3 years, 6 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[M60] exo: Fix multi-display hardware cursor This CL fixes crashes in extended desktop mode caused by incorrect parenting of the cursor surface, as well as cases where the cursor was captured with an incorrect transform or hotspot: 1) The mouse enters a display with a different DSF or UI scale. 2) The internal display is not the primary display. 3) The display is rotated. It also adds a TODO for an accessibility regression. TBR=reveman@chromium.org NOTRY=true NOPRESUBMIT=true BUG=631136 BUG=642894 TEST=caroline: Cursor parenting and scaling is correct for each display. TEST=caroline: Cursor on rotated displays has correct orientation. Review-Url: https://codereview.chromium.org/2780623002 Cr-Original-Commit-Position: refs/heads/master@{#476353} Review-Url: https://codereview.chromium.org/2924873008 Cr-Commit-Position: refs/branch-heads/3112@{#263} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/e0a90e7641fe7a24179747861292ef199dae85e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -95 lines) Patch
M chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M components/exo/pointer.h View 4 chunks +7 lines, -8 lines 0 comments Download
M components/exo/pointer.cc View 10 chunks +65 lines, -70 lines 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/exo/wm_helper.h View 4 chunks +6 lines, -2 lines 0 comments Download
M components/exo/wm_helper.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/exo/wm_helper_ash.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/exo/wm_helper_ash.cc View 3 chunks +15 lines, -4 lines 0 comments Download
M components/exo/wm_helper_mus.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/exo/wm_helper_mus.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M ui/aura/client/cursor_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/client/cursor_client_observer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/test/test_cursor_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/test_cursor_client.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/wm/core/cursor_manager.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/wm/core/cursor_manager.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924873008/1
3 years, 6 months ago (2017-06-08 20:37:50 UTC) #2
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 20:38:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0a90e7641fe7a24179747861292...

Powered by Google App Engine
This is Rietveld 408576698