Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2924813002:
Make ThreadTestHelper sequence-friendly. (Closed)
|
Created:
3 years, 6 months ago by gab Modified:
3 years, 6 months ago Reviewers:
Paweł Hajdan Jr. CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake ThreadTestHelper sequence-friendly.
Required @ https://crbug.com/552552#c17
PS: SequenceTestHelper sounded too generic of a name... decided to keep
the name as-is, this isn't used all that much anyways...
BUG=675631, 552552
Review-Url: https://codereview.chromium.org/2924813002
Cr-Commit-Position: refs/heads/master@{#477665}
Committed: https://chromium.googlesource.com/chromium/src/+/d9374411781498797ca4bc987475b5e483018d49
Patch Set 1 #Patch Set 2 : fix typo #
Messages
Total messages: 24 (20 generated)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
gab@chromium.org changed reviewers: + phajdan.jr@chromium.org
Pawel PTaL, thanks!
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM Thanks!
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496847062882420,
"parent_rev": "7f135c9f1fc53033408152e5024c1fe30c3bb3bb", "commit_rev":
"d9374411781498797ca4bc987475b5e483018d49"}
Message was sent while issue was closed.
Description was changed from ========== Make ThreadTestHelper sequence-friendly. Required @ https://crbug.com/552552#c17 PS: SequenceTestHelper sounded too generic of a name... decided to keep the name as-is, this isn't used all that much anyways... BUG=675631, 552552 ========== to ========== Make ThreadTestHelper sequence-friendly. Required @ https://crbug.com/552552#c17 PS: SequenceTestHelper sounded too generic of a name... decided to keep the name as-is, this isn't used all that much anyways... BUG=675631, 552552 Review-Url: https://codereview.chromium.org/2924813002 Cr-Commit-Position: refs/heads/master@{#477665} Committed: https://chromium.googlesource.com/chromium/src/+/d9374411781498797ca4bc987475... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d9374411781498797ca4bc987475... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
