Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2924793002:
Refactor CanBe{Back,For}wardCaretPosition() (Closed)
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor CanBe{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2924793002
Cr-Commit-Position: refs/heads/master@{#477499}
Committed: https://chromium.googlesource.com/chromium/src/+/73ba34deaf39eb774f8541d84480833527a47572
Patch Set 1 : 2017-06-06T17:16:17 #Patch Set 2 : 2017-06-06T17:25:09 #Messages
Total messages: 20 (16 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== 2017-06-06T17:06:21 BUG= 2017-06-06T17:06:16 ========== to ========== 2017-06-06T17:06:21 BUG=707655 2017-06-06T17:06:16 ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-06T17:06:21 BUG=707655 2017-06-06T17:06:16 ========== to ========== 2017-06-06T17:06:21 BUG=707656 2017-06-06T17:06:16 ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
2017-06-06T17:06:21
BUG=707656
2017-06-06T17:06:16
==========
to
==========
Re-factor Can{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
==========
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL Since code review tool doesn't diff well for in-place change in PS#1, I move code fragment before caller and re-factor it.
Description was changed from
==========
Re-factor Can{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
==========
to
==========
Refactor Can{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
==========
Description was changed from
==========
Refactor Can{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
==========
to
==========
Refactor CanBe{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496796945582110,
"parent_rev": "d458772d4250347ab3ed34e8cf682b16658d208a", "commit_rev":
"73ba34deaf39eb774f8541d84480833527a47572"}
Message was sent while issue was closed.
Description was changed from
==========
Refactor CanBe{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
==========
to
==========
Refactor CanBe{Back,For}wardCaretPosition()
This patch moves common code fragment in |{Back,For}wardCaretPosition()| into
|DoesContinueOnNextLine()|, with cleanup, to reduce source code size for
improving code health.
BUG=707656
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2924793002
Cr-Commit-Position: refs/heads/master@{#477499}
Committed:
https://chromium.googlesource.com/chromium/src/+/73ba34deaf39eb774f8541d84480...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/73ba34deaf39eb774f8541d84480... |
