Allow device/bluetooth to build on the macOS 10.13 SDK

Allow device/bluetooth to build on the macOS 10.13 SDK

Some CoreBluetooth declarations tweaked in ways that are not compatible.

Also changes import/includes to match style guide:

https://google.github.io/styleguide/objcguide.xml?showone=_import_and__include#_import_and__include

BUG=729906
Review-Url: https://codereview.chromium.org/2924753002
Cr-Commit-Position: refs/heads/master@{#477867}
Committed: https://chromium.googlesource.com/chromium/src/+/724d9901b9f8f44e67a9b9d6da0722bb443e5d0c

[tapted, 2017-06-06 04:45:17]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 04:45:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 04:59:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tapted, 2017-06-06 05:07:42]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 05:07:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 05:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 05:21:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-06-06 05:33:46]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 05:34:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 05:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 05:51:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tapted, 2017-06-06 06:31:13]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 06:31:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-06-06 07:51:24]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 07:51:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-06-06 08:09:55]

Description was changed from

==========
Allow device/bluetooth to build on the macOS 10.13 SDK

BUG=729906
==========

to

==========
Allow device/bluetooth to build on the macOS 10.13 SDK

Some CoreBluetooth declarations tweaked in ways that are not compatible.

BUG=729906
==========

[tapted, 2017-06-06 08:09:55]

tapted@chromium.org changed reviewers:
+ ortuno@chromium.org

[tapted, 2017-06-06 08:11:47]

Hi gio, please take a look. I ran device_unittests locally (after building both
with the 10.13 sdk and the usual one we use). all passed.

[commit-bot: I haz the power, 2017-06-06 09:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 09:07:45]

Dry run: This issue passed the CQ dry run.

[ortuno, 2017-06-06 23:08:43]

On 2017/06/06 at 08:11:47, tapted wrote:
> Hi gio, please take a look. I ran device_unittests locally (after building
both with the 10.13 sdk and the usual one we use). all passed.

Interesting. I'm surprised we didn't have to change our fakes/mocks to use
CBCentralState e.g.:

https://cs.chromium.org/chromium/src/device/bluetooth/test/mock_bluetooth_cen...

How could our tests pass if the fakes are using the old enums?

[tapted, 2017-06-06 23:29:36]

On 2017/06/06 23:08:43, ortuno wrote:
> On 2017/06/06 at 08:11:47, tapted wrote:
> > Hi gio, please take a look. I ran device_unittests locally (after building
> both with the 10.13 sdk and the usual one we use). all passed.
> 
> Interesting. I'm surprised we didn't have to change our fakes/mocks to use
> CBCentralState e.g.:
> 
>
https://cs.chromium.org/chromium/src/device/bluetooth/test/mock_bluetooth_cen...
> 
> How could our tests pass if the fakes are using the old enums?

The enums are still present in the 10.13 SDK, but deprecated. We only warn about
using deprecated things in the SDK when the deployment target has reached the
SDK version where they were deprecated. We currently target 10.9, so Chrome is
allowed to use anything that was deprecated in 10.10 or later without warning.
Their values also happen to match exactly. It's only when the compiler sees a
comparison operation that it complains of different enum types.

So MockCentralManager adding a property using the deprecated enum isn't a
problem, and there's no reason there for the compiler to think that it's
overriding with a different return type. There's also no runtime check.

But it probably should be updated :). I'll upload a new CL.

[tapted, 2017-06-07 06:44:14]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 06:44:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 07:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 07:59:59]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-06-07 09:04:47]

On 2017/06/06 23:29:36, tapted wrote:
> But it probably should be updated :). I'll upload a new CL.


Done. PTAL.

[ortuno, 2017-06-08 02:50:41]

lgtm. Thanks for the include->import changes. Should we change anything in
https://cs.chromium.org/chromium/src/device/bluetooth/test/mock_bluetooth_cbp...

[ortuno, 2017-06-08 02:52:41]

Description was changed from

==========
Allow device/bluetooth to build on the macOS 10.13 SDK

Some CoreBluetooth declarations tweaked in ways that are not compatible.

BUG=729906
==========

to

==========
Allow device/bluetooth to build on the macOS 10.13 SDK

Some CoreBluetooth declarations tweaked in ways that are not compatible.

Also changes import/includes to match style guide:

https://google.github.io/styleguide/objcguide.xml?showone=_import_and__includ...

BUG=729906
==========

[tapted, 2017-06-08 02:55:01]

Thanks Gio!

On 2017/06/08 02:50:41, ortuno wrote:
> lgtm. Thanks for the include->import changes. Should we change anything in
>
https://cs.chromium.org/chromium/src/device/bluetooth/test/mock_bluetooth_cbp...

Nah - it's fine to mock out the NSUUID* identifier the same way - ObjC doesn't
really care where the method is coming from in the inheritance chain.

[tapted, 2017-06-08 02:56:39]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-06-08 02:56:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 03:00:46]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1496890599020740,
"parent_rev": "c2fa68105149dc84c603a46f73928fc16c528a64", "commit_rev":
"724d9901b9f8f44e67a9b9d6da0722bb443e5d0c"}

[commit-bot: I haz the power, 2017-06-08 03:01:00]

Description was changed from

==========
Allow device/bluetooth to build on the macOS 10.13 SDK

Some CoreBluetooth declarations tweaked in ways that are not compatible.

Also changes import/includes to match style guide:

https://google.github.io/styleguide/objcguide.xml?showone=_import_and__includ...

BUG=729906
==========

to

==========
Allow device/bluetooth to build on the macOS 10.13 SDK

Some CoreBluetooth declarations tweaked in ways that are not compatible.

Also changes import/includes to match style guide:

https://google.github.io/styleguide/objcguide.xml?showone=_import_and__includ...

BUG=729906

Review-Url: https://codereview.chromium.org/2924753002
Cr-Commit-Position: refs/heads/master@{#477867}
Committed:
https://chromium.googlesource.com/chromium/src/+/724d9901b9f8f44e67a9b9d6da07...
==========

[commit-bot: I haz the power, 2017-06-08 03:01:02]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/724d9901b9f8f44e67a9b9d6da07...