Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2924673003: [MD Bookmarks] Make shift-selection behave well with no anchor. (Closed)

Created:
3 years, 6 months ago by calamity
Modified:
3 years, 6 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Make shift-selection behave well with no anchor. This CL makes shift-selection use the old focused index as an anchor which makes shift selecting with the keyboard on page load work as expected. BUG=692844 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2924673003 Cr-Commit-Position: refs/heads/master@{#477557} Committed: https://chromium.googlesource.com/chromium/src/+/6dacd834a9f5bd10f3de9e4780b4d48064370f95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/resources/md_bookmarks/list.js View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
calamity
3 years, 6 months ago (2017-06-06 08:10:59 UTC) #3
tsergeant
lgtm
3 years, 6 months ago (2017-06-07 01:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673003/1
3 years, 6 months ago (2017-06-07 03:58:09 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 05:42:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6dacd834a9f5bd10f3de9e4780b4...

Powered by Google App Engine
This is Rietveld 408576698