Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2924663002: Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst." (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst." This reverts commit b7661431bf840b8cad5fe45922997ce163a63322. (I'm reverting just so I can get the tree green and then fix offline.) TBR=jmesserly@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7bd51eb191f66110bc61be3859433368544fafd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M pkg/compiler/lib/src/closure.dart View 4 chunks +15 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Emily Fortuna
3 years, 6 months ago (2017-06-05 20:06:47 UTC) #1
Emily Fortuna
Committed patchset #1 (id:1) manually as 7bd51eb191f66110bc61be3859433368544fafd9 (presubmit successful).
3 years, 6 months ago (2017-06-05 20:07:01 UTC) #3
Jennifer Messerly
3 years, 6 months ago (2017-06-05 20:53:27 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698